Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: Jim Blandy <jimb@redhat.com>, Elena Zannoni <ezannoni@redhat.com>,
	gdb-patches@sources.redhat.com
Subject: Re: [drow@mvista.com: Re: RFA: LOC_COMPUTED support]
Date: Fri, 21 Feb 2003 17:14:00 -0000	[thread overview]
Message-ID: <20030221171435.GB14877@nevyn.them.org> (raw)
In-Reply-To: <3E565E09.9020706@redhat.com>

On Fri, Feb 21, 2003 at 12:12:41PM -0500, Andrew Cagney wrote:
> Just a generic heads up on the structure of this code and these, er, 
> batons (from the point of view of the architecture).
> 
> This is implementing something like (I've not hacked C++ in > 10 years):
> 
> 	// some base classes
> 	class A;
> 	class B;
> 
> 	// a derived class (wonder if I got the order right).
> 	class B::class B1;
> 
> 	// A `uses' B but is parameterized with the specific instance
> 	class A->method (class B B);
> 
> in C.
> 
> I honestly think that using baton's distract from what is a simple O-O 
> construct and standard O-O terminology.
> 
> The frame and architecture code both reflect this structure - pass in 
> the object and then use methods supplied as part of the object.
> 
> Once all this is settled, I think I'll look to re-factor (hmm, buzword) 
> the code so that its structure better refects what is going on.

I don't think I agree with you on this, but if you want to change it by
all means post a patch for some concrete discussion :)  This is another
point when I am willing to sacrifice a certain amount of clarity to not
carry around an extra set of method pointers; there are a _large_
number of these batons.

I'd rather discuss a transition to C++ than any particular instance of
this problem.  Do you think it's feasible?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2003-02-21 17:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20030213211157.GA13537@nevyn.them.org>
2003-02-20 23:08 ` Jim Blandy
2003-02-21 15:24   ` Daniel Jacobowitz
2003-02-21 17:08     ` Andrew Cagney
2003-02-21 17:14       ` Daniel Jacobowitz [this message]
2003-02-21 17:22         ` Andrew Cagney
2003-02-21 17:19     ` Joel Brobecker
2003-02-24  3:30 Michael Elizabeth Chastain
2003-02-24  4:15 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030221171435.GB14877@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=ac131313@redhat.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox