From: Jason Molenda <jason-swarelist@molenda.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: Elena Zannoni <ezannoni@redhat.com>,
Daniel Jacobowitz <drow@mvista.com>,
David Carlton <carlton@math.stanford.edu>,
gdb-patches@sources.redhat.com, jjohnstn@redhat.com
Subject: Re: Fix committed for mi-syn-frames fails (was: Re: PATCH RFA: Fix MI stack frame output for synthetic frames)
Date: Thu, 06 Feb 2003 18:27:00 -0000 [thread overview]
Message-ID: <20030206102747.A10575@molenda.com> (raw)
In-Reply-To: <3E42A78C.5040908@redhat.com>; from ac131313@redhat.com on Thu, Feb 06, 2003 at 01:21:00PM -0500
On Thu, Feb 06, 2003 at 01:21:00PM -0500, Andrew Cagney wrote:
>
> Pss, add a comment explaining why the code is written that way :-)
>
I don't think anyone looks to the testsuite source code for brevity
and logical expression, but I don't have any real preference.
Patch below committed.
2003-02-06 Jason Molenda (jason-cl@molenda.com)
* gdb.mi/mi-syn-frame.c (subroutine): Add a comment explaining
why the code is written that way.
Index: gdb.mi/mi-syn-frame.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-syn-frame.c,v
retrieving revision 1.2
diff -u -p -r1.2 mi-syn-frame.c
--- gdb.mi/mi-syn-frame.c 6 Feb 2003 06:27:01 -0000 1.2
+++ gdb.mi/mi-syn-frame.c 6 Feb 2003 18:25:01 -0000
@@ -43,6 +43,10 @@ handler (int sig)
subroutine (sig);
}
+/* The first statement in subroutine () is a place for a breakpoint.
+ Without it, the breakpoint is put on the while comparison and will
+ be hit at each iteration. */
+
void
subroutine (int in)
{
next prev parent reply other threads:[~2003-02-06 18:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-08 14:22 PATCH: Fix MI stack frame output for synthetic frames Jason Molenda
2002-11-08 14:38 ` Andrew Cagney
2002-11-08 14:46 ` Jason Molenda
2002-11-08 15:56 ` Andrew Cagney
2002-11-09 0:47 ` PATCH RFA: " Jason Molenda
2002-11-09 2:13 ` Jason Molenda
2002-11-15 11:16 ` Ping on two MI patches Jason Molenda
2003-02-02 5:52 ` PATCH RFA: Fix MI stack frame output for synthetic frames Andrew Cagney
2003-02-02 17:38 ` Mark Kettenis
2003-02-02 18:23 ` Andrew Cagney
2003-02-02 20:51 ` Mark Kettenis
2003-02-03 18:15 ` David Carlton
2003-02-03 18:27 ` Jason Molenda
2003-02-03 18:34 ` Daniel Jacobowitz
2003-02-04 8:09 ` Jason Molenda
2003-02-05 8:28 ` Jason Molenda
2003-02-05 13:59 ` Daniel Jacobowitz
2003-02-05 14:54 ` Elena Zannoni
2003-02-06 6:28 ` Fix committed for mi-syn-frames fails (was: Re: PATCH RFA: Fix MI stack frame output for synthetic frames) Jason Molenda
2003-02-06 6:31 ` Jason Molenda
2003-02-06 17:01 ` David Carlton
2003-02-06 18:21 ` Andrew Cagney
2003-02-06 18:27 ` Jason Molenda [this message]
2003-02-06 17:10 Michael Elizabeth Chastain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030206102747.A10575@molenda.com \
--to=jason-swarelist@molenda.com \
--cc=ac131313@redhat.com \
--cc=carlton@math.stanford.edu \
--cc=drow@mvista.com \
--cc=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jjohnstn@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox