From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24289 invoked by alias); 6 Feb 2003 18:27:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24272 invoked from network); 6 Feb 2003 18:27:48 -0000 Received: from unknown (HELO molenda.com) (192.220.74.81) by 172.16.49.205 with SMTP; 6 Feb 2003 18:27:48 -0000 Received: (qmail 11654 invoked by uid 19025); 6 Feb 2003 18:27:47 -0000 Date: Thu, 06 Feb 2003 18:27:00 -0000 From: Jason Molenda To: Andrew Cagney Cc: Elena Zannoni , Daniel Jacobowitz , David Carlton , gdb-patches@sources.redhat.com, jjohnstn@redhat.com Subject: Re: Fix committed for mi-syn-frames fails (was: Re: PATCH RFA: Fix MI stack frame output for synthetic frames) Message-ID: <20030206102747.A10575@molenda.com> References: <3E3CB218.1020706@redhat.com> <20030203102748.A75701@molenda.com> <20030203183441.GA27429@nevyn.them.org> <20030204000936.A19984@molenda.com> <20030205002416.A75501@molenda.com> <20030205135947.GA30516@nevyn.them.org> <15937.9876.260141.789359@localhost.redhat.com> <20030205222835.A985@molenda.com> <3E42A78C.5040908@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <3E42A78C.5040908@redhat.com>; from ac131313@redhat.com on Thu, Feb 06, 2003 at 01:21:00PM -0500 X-SW-Source: 2003-02/txt/msg00220.txt.bz2 On Thu, Feb 06, 2003 at 01:21:00PM -0500, Andrew Cagney wrote: > > Pss, add a comment explaining why the code is written that way :-) > I don't think anyone looks to the testsuite source code for brevity and logical expression, but I don't have any real preference. Patch below committed. 2003-02-06 Jason Molenda (jason-cl@molenda.com) * gdb.mi/mi-syn-frame.c (subroutine): Add a comment explaining why the code is written that way. Index: gdb.mi/mi-syn-frame.c =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-syn-frame.c,v retrieving revision 1.2 diff -u -p -r1.2 mi-syn-frame.c --- gdb.mi/mi-syn-frame.c 6 Feb 2003 06:27:01 -0000 1.2 +++ gdb.mi/mi-syn-frame.c 6 Feb 2003 18:25:01 -0000 @@ -43,6 +43,10 @@ handler (int sig) subroutine (sig); } +/* The first statement in subroutine () is a place for a breakpoint. + Without it, the breakpoint is put on the while comparison and will + be hit at each iteration. */ + void subroutine (int in) {