From: Fred Fish <fnf@public.ninemoons.com>
To: gdb-patches@sources.redhat.com
Cc: fnf@intrinsity.com
Subject: [PATCH] Fix several operator precedence bugs
Date: Wed, 05 Feb 2003 17:16:00 -0000 [thread overview]
Message-ID: <200302051716.h15HGANM001905@fred.ninemoons.com> (raw)
2003-02-05 Fred Fish <fnf@intrinsity.com>
* remote-e7000.c (e7000_drain_command): Fix precedence problem with
'=' and '!='.
* rdi-share/ardi.c (wait_for_debug_message): Fix precedence problem
with '&' and '=='.
(angel_RDI_info): Ditto.
* infttrace.c (threads_continue_all_but_one): Fix precedence problem
with '&' and '!='.
(threads_continue_all_with_signals): Ditto.
Index: infttrace.c
===================================================================
RCS file: /cvs/src/src/gdb/infttrace.c,v
retrieving revision 1.24
diff -c -p -r1.24 infttrace.c
*** infttrace.c 12 Dec 2002 01:39:34 -0000 1.24
--- infttrace.c 5 Feb 2003 17:12:47 -0000
*************** threads_continue_all_but_one (lwpid_t gd
*** 3951,3957 ****
* state.tts_flags & TTS_STATEMASK == TTS_WASSUSPENDED
*/
if (debug_on)
! if (state.tts_flags & TTS_STATEMASK != TTS_WASSUSPENDED)
printf ("About to continue non-stopped thread %d\n", scan_tid);
#endif
--- 3951,3957 ----
* state.tts_flags & TTS_STATEMASK == TTS_WASSUSPENDED
*/
if (debug_on)
! if ((state.tts_flags & TTS_STATEMASK) != TTS_WASSUSPENDED)
printf ("About to continue non-stopped thread %d\n", scan_tid);
#endif
*************** threads_continue_all_with_signals (lwpid
*** 4085,4091 ****
#ifdef THREAD_DEBUG
if (debug_on)
! if (state.tts_flags & TTS_STATEMASK != TTS_WASSUSPENDED)
warning ("About to continue non-stopped thread %d\n", scan_tid);
#endif
--- 4085,4091 ----
#ifdef THREAD_DEBUG
if (debug_on)
! if ((state.tts_flags & TTS_STATEMASK) != TTS_WASSUSPENDED)
warning ("About to continue non-stopped thread %d\n", scan_tid);
#endif
Index: remote-e7000.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-e7000.c,v
retrieving revision 1.32
diff -c -p -r1.32 remote-e7000.c
*** remote-e7000.c 2 Feb 2003 05:46:14 -0000 1.32
--- remote-e7000.c 5 Feb 2003 17:12:49 -0000
*************** e7000_drain_command (char *args, int fro
*** 1812,1818 ****
puts_e7000debug ("end\r");
putchar_e7000 (CTRLC);
! while ((c = readchar (1) != -1))
{
if (quit_flag)
{
--- 1812,1818 ----
puts_e7000debug ("end\r");
putchar_e7000 (CTRLC);
! while ((c = readchar (1)) != -1)
{
if (quit_flag)
{
Index: rdi-share/ardi.c
===================================================================
RCS file: /cvs/src/src/gdb/rdi-share/ardi.c,v
retrieving revision 1.2
diff -c -p -r1.2 ardi.c
*** rdi-share/ardi.c 12 Oct 2000 22:56:31 -0000 1.2
--- rdi-share/ardi.c 5 Feb 2003 17:12:54 -0000
*************** static int wait_for_debug_message(int *r
*** 154,160 ****
unpack_message(BUFFERDATA((*packet)->pk_buffer), "%w%w%w%w%w", &reason, debugID,
OSinfo1, OSinfo2, status);
! if (reason&0xffffff == ADP_HADPUnrecognised)
return RDIError_UnimplementedMessage;
if (reason != (unsigned ) *rcode) {
if((reason&0xffffff) == ADP_HADPUnrecognised)
--- 154,160 ----
unpack_message(BUFFERDATA((*packet)->pk_buffer), "%w%w%w%w%w", &reason, debugID,
OSinfo1, OSinfo2, status);
! if ((reason&0xffffff) == ADP_HADPUnrecognised)
return RDIError_UnimplementedMessage;
if (reason != (unsigned ) *rcode) {
if((reason&0xffffff) == ADP_HADPUnrecognised)
*************** int angel_RDI_info(unsigned type, ARMwor
*** 1842,1848 ****
len +=msgbuild(BUFFERDATA(packet->pk_buffer)+20, "%b%b%b%b%b", cpnum,
cpd->regdesc[cpnum].rmin, cpd->regdesc[cpnum].rmax,
cpd->regdesc[cpnum].nbytes, cpd->regdesc[cpnum].access);
! if (cpd->regdesc[cpnum].access&0x3 == 0x3){
len += msgbuild(BUFFERDATA(packet->pk_buffer)+25, "%b%b%b%b%b",
cpd->regdesc[cpnum].accessinst.cprt.read_b0,
cpd->regdesc[cpnum].accessinst.cprt.read_b1,
--- 1842,1848 ----
len +=msgbuild(BUFFERDATA(packet->pk_buffer)+20, "%b%b%b%b%b", cpnum,
cpd->regdesc[cpnum].rmin, cpd->regdesc[cpnum].rmax,
cpd->regdesc[cpnum].nbytes, cpd->regdesc[cpnum].access);
! if ((cpd->regdesc[cpnum].access&0x3) == 0x3){
len += msgbuild(BUFFERDATA(packet->pk_buffer)+25, "%b%b%b%b%b",
cpd->regdesc[cpnum].accessinst.cprt.read_b0,
cpd->regdesc[cpnum].accessinst.cprt.read_b1,
next reply other threads:[~2003-02-05 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-05 17:16 Fred Fish [this message]
2003-02-06 4:56 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200302051716.h15HGANM001905@fred.ninemoons.com \
--to=fnf@public.ninemoons.com \
--cc=fnf@intrinsity.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox