From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 898 invoked by alias); 5 Feb 2003 17:16:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 878 invoked from network); 5 Feb 2003 17:16:18 -0000 Received: from unknown (HELO fred.ninemoons.com) (68.14.214.217) by 172.16.49.205 with SMTP; 5 Feb 2003 17:16:18 -0000 Received: from fred.ninemoons.com (localhost.localdomain [127.0.0.1]) by fred.ninemoons.com (8.12.5/8.12.5) with ESMTP id h15HGBWJ001907; Wed, 5 Feb 2003 10:16:16 -0700 Received: (from fnf@localhost) by fred.ninemoons.com (8.12.5/8.12.5/Submit) id h15HGANM001905; Wed, 5 Feb 2003 10:16:10 -0700 From: Fred Fish Message-Id: <200302051716.h15HGANM001905@fred.ninemoons.com> Subject: [PATCH] Fix several operator precedence bugs To: gdb-patches@sources.redhat.com Date: Wed, 05 Feb 2003 17:16:00 -0000 Cc: fnf@intrinsity.com Reply-To: fnf@intrinsity.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2003-02/txt/msg00190.txt.bz2 2003-02-05 Fred Fish * remote-e7000.c (e7000_drain_command): Fix precedence problem with '=' and '!='. * rdi-share/ardi.c (wait_for_debug_message): Fix precedence problem with '&' and '=='. (angel_RDI_info): Ditto. * infttrace.c (threads_continue_all_but_one): Fix precedence problem with '&' and '!='. (threads_continue_all_with_signals): Ditto. Index: infttrace.c =================================================================== RCS file: /cvs/src/src/gdb/infttrace.c,v retrieving revision 1.24 diff -c -p -r1.24 infttrace.c *** infttrace.c 12 Dec 2002 01:39:34 -0000 1.24 --- infttrace.c 5 Feb 2003 17:12:47 -0000 *************** threads_continue_all_but_one (lwpid_t gd *** 3951,3957 **** * state.tts_flags & TTS_STATEMASK == TTS_WASSUSPENDED */ if (debug_on) ! if (state.tts_flags & TTS_STATEMASK != TTS_WASSUSPENDED) printf ("About to continue non-stopped thread %d\n", scan_tid); #endif --- 3951,3957 ---- * state.tts_flags & TTS_STATEMASK == TTS_WASSUSPENDED */ if (debug_on) ! if ((state.tts_flags & TTS_STATEMASK) != TTS_WASSUSPENDED) printf ("About to continue non-stopped thread %d\n", scan_tid); #endif *************** threads_continue_all_with_signals (lwpid *** 4085,4091 **** #ifdef THREAD_DEBUG if (debug_on) ! if (state.tts_flags & TTS_STATEMASK != TTS_WASSUSPENDED) warning ("About to continue non-stopped thread %d\n", scan_tid); #endif --- 4085,4091 ---- #ifdef THREAD_DEBUG if (debug_on) ! if ((state.tts_flags & TTS_STATEMASK) != TTS_WASSUSPENDED) warning ("About to continue non-stopped thread %d\n", scan_tid); #endif Index: remote-e7000.c =================================================================== RCS file: /cvs/src/src/gdb/remote-e7000.c,v retrieving revision 1.32 diff -c -p -r1.32 remote-e7000.c *** remote-e7000.c 2 Feb 2003 05:46:14 -0000 1.32 --- remote-e7000.c 5 Feb 2003 17:12:49 -0000 *************** e7000_drain_command (char *args, int fro *** 1812,1818 **** puts_e7000debug ("end\r"); putchar_e7000 (CTRLC); ! while ((c = readchar (1) != -1)) { if (quit_flag) { --- 1812,1818 ---- puts_e7000debug ("end\r"); putchar_e7000 (CTRLC); ! while ((c = readchar (1)) != -1) { if (quit_flag) { Index: rdi-share/ardi.c =================================================================== RCS file: /cvs/src/src/gdb/rdi-share/ardi.c,v retrieving revision 1.2 diff -c -p -r1.2 ardi.c *** rdi-share/ardi.c 12 Oct 2000 22:56:31 -0000 1.2 --- rdi-share/ardi.c 5 Feb 2003 17:12:54 -0000 *************** static int wait_for_debug_message(int *r *** 154,160 **** unpack_message(BUFFERDATA((*packet)->pk_buffer), "%w%w%w%w%w", &reason, debugID, OSinfo1, OSinfo2, status); ! if (reason&0xffffff == ADP_HADPUnrecognised) return RDIError_UnimplementedMessage; if (reason != (unsigned ) *rcode) { if((reason&0xffffff) == ADP_HADPUnrecognised) --- 154,160 ---- unpack_message(BUFFERDATA((*packet)->pk_buffer), "%w%w%w%w%w", &reason, debugID, OSinfo1, OSinfo2, status); ! if ((reason&0xffffff) == ADP_HADPUnrecognised) return RDIError_UnimplementedMessage; if (reason != (unsigned ) *rcode) { if((reason&0xffffff) == ADP_HADPUnrecognised) *************** int angel_RDI_info(unsigned type, ARMwor *** 1842,1848 **** len +=msgbuild(BUFFERDATA(packet->pk_buffer)+20, "%b%b%b%b%b", cpnum, cpd->regdesc[cpnum].rmin, cpd->regdesc[cpnum].rmax, cpd->regdesc[cpnum].nbytes, cpd->regdesc[cpnum].access); ! if (cpd->regdesc[cpnum].access&0x3 == 0x3){ len += msgbuild(BUFFERDATA(packet->pk_buffer)+25, "%b%b%b%b%b", cpd->regdesc[cpnum].accessinst.cprt.read_b0, cpd->regdesc[cpnum].accessinst.cprt.read_b1, --- 1842,1848 ---- len +=msgbuild(BUFFERDATA(packet->pk_buffer)+20, "%b%b%b%b%b", cpnum, cpd->regdesc[cpnum].rmin, cpd->regdesc[cpnum].rmax, cpd->regdesc[cpnum].nbytes, cpd->regdesc[cpnum].access); ! if ((cpd->regdesc[cpnum].access&0x3) == 0x3){ len += msgbuild(BUFFERDATA(packet->pk_buffer)+25, "%b%b%b%b%b", cpd->regdesc[cpnum].accessinst.cprt.read_b0, cpd->regdesc[cpnum].accessinst.cprt.read_b1,