Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@chello.nl>
To: gdb-patches@sources.redhat.com
Subject: [PATCH] Testsuite: deal gracefully with lack of pthreads
Date: Sat, 01 Feb 2003 16:24:00 -0000	[thread overview]
Message-ID: <200302011624.h11GOTvb049469@elgar.kettenis.dyndns.org> (raw)

This patch parallels what Daniel has done to the tests in the
gdb.threads subdir.

Elana, Andrew, OK to check this in?

There's probably one issue: We have a ChangeLog in both testsuite and
testsuite/gdb.mi.  Both seem to be in used for MI tests.  Which one is
preferred, and can we think of a way to avoid that both are used?

Mark

Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* gdb669.exp, mi-pthreads.exp, mi1-pthreads.exp: Return instead of
	calling gdb_suppress_entire_file.

Index: gdb669.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/gdb669.exp,v
retrieving revision 1.3
diff -u -p -r1.3 gdb669.exp
--- gdb669.exp 4 Jan 2003 15:37:40 -0000 1.3
+++ gdb669.exp 1 Feb 2003 16:20:29 -0000
@@ -179,10 +179,8 @@ set srcfile "$testfile.c"
 set binfile "$objdir/$subdir/$testfile"
 
 set options [list debug incdir=$objdir]
-if  {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options]
-     != "" } {
-  gdb_suppress_entire_file \
-    "Testcase compile failed, so all tests in this file will automatically fail."
+if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } {
+    return -1
 }
 
 mi_gdb_reinitialize_dir $srcdir/$subdir
Index: mi-pthreads.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-pthreads.exp,v
retrieving revision 1.5
diff -u -p -r1.5 mi-pthreads.exp
--- mi-pthreads.exp 7 Jan 2003 03:28:14 -0000 1.5
+++ mi-pthreads.exp 1 Feb 2003 16:20:29 -0000
@@ -208,10 +208,8 @@ set srcfile "$testfile.c"
 set binfile "$objdir/$subdir/$testfile"
 
 set options [list debug incdir=$objdir]
-if  {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options]
-     != "" } {
-  gdb_suppress_entire_file \
-    "Testcase compile failed, so all tests in this file will automatically fail."
+if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } {
+    return -1
 }
 
 mi_gdb_reinitialize_dir $srcdir/$subdir
Index: mi1-pthreads.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi1-pthreads.exp,v
retrieving revision 1.3
diff -u -p -r1.3 mi1-pthreads.exp
--- mi1-pthreads.exp 7 Jan 2003 03:28:14 -0000 1.3
+++ mi1-pthreads.exp 1 Feb 2003 16:20:29 -0000
@@ -208,10 +208,8 @@ set srcfile "$testfile.c"
 set binfile "$objdir/$subdir/$testfile"
 
 set options [list debug incdir=$objdir]
-if  {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options]
-     != "" } {
-  gdb_suppress_entire_file \
-    "Testcase compile failed, so all tests in this file will automatically fail."
+if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } {
+    return -1
 }
 
 mi_gdb_reinitialize_dir $srcdir/$subdir


             reply	other threads:[~2003-02-01 16:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-01 16:24 Mark Kettenis [this message]
2003-02-01 16:40 ` Andrew Cagney
2003-02-01 22:37   ` Mark Kettenis
2003-02-01 17:47 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200302011624.h11GOTvb049469@elgar.kettenis.dyndns.org \
    --to=kettenis@chello.nl \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox