From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16948 invoked by alias); 1 Feb 2003 16:24:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16819 invoked from network); 1 Feb 2003 16:24:31 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.212) by 172.16.49.205 with SMTP; 1 Feb 2003 16:24:31 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6/8.12.5) with ESMTP id h11GOTx6000714 for ; Sat, 1 Feb 2003 17:24:29 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6/8.12.6) with ESMTP id h11GOTuj049472 for ; Sat, 1 Feb 2003 17:24:29 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6/8.12.6/Submit) id h11GOTvb049469; Sat, 1 Feb 2003 17:24:29 +0100 (CET) Date: Sat, 01 Feb 2003 16:24:00 -0000 Message-Id: <200302011624.h11GOTvb049469@elgar.kettenis.dyndns.org> From: Mark Kettenis To: gdb-patches@sources.redhat.com Subject: [PATCH] Testsuite: deal gracefully with lack of pthreads X-SW-Source: 2003-02/txt/msg00023.txt.bz2 This patch parallels what Daniel has done to the tests in the gdb.threads subdir. Elana, Andrew, OK to check this in? There's probably one issue: We have a ChangeLog in both testsuite and testsuite/gdb.mi. Both seem to be in used for MI tests. Which one is preferred, and can we think of a way to avoid that both are used? Mark Index: ChangeLog from Mark Kettenis * gdb669.exp, mi-pthreads.exp, mi1-pthreads.exp: Return instead of calling gdb_suppress_entire_file. Index: gdb669.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/gdb669.exp,v retrieving revision 1.3 diff -u -p -r1.3 gdb669.exp --- gdb669.exp 4 Jan 2003 15:37:40 -0000 1.3 +++ gdb669.exp 1 Feb 2003 16:20:29 -0000 @@ -179,10 +179,8 @@ set srcfile "$testfile.c" set binfile "$objdir/$subdir/$testfile" set options [list debug incdir=$objdir] -if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] - != "" } { - gdb_suppress_entire_file \ - "Testcase compile failed, so all tests in this file will automatically fail." +if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } { + return -1 } mi_gdb_reinitialize_dir $srcdir/$subdir Index: mi-pthreads.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-pthreads.exp,v retrieving revision 1.5 diff -u -p -r1.5 mi-pthreads.exp --- mi-pthreads.exp 7 Jan 2003 03:28:14 -0000 1.5 +++ mi-pthreads.exp 1 Feb 2003 16:20:29 -0000 @@ -208,10 +208,8 @@ set srcfile "$testfile.c" set binfile "$objdir/$subdir/$testfile" set options [list debug incdir=$objdir] -if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] - != "" } { - gdb_suppress_entire_file \ - "Testcase compile failed, so all tests in this file will automatically fail." +if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } { + return -1 } mi_gdb_reinitialize_dir $srcdir/$subdir Index: mi1-pthreads.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi1-pthreads.exp,v retrieving revision 1.3 diff -u -p -r1.3 mi1-pthreads.exp --- mi1-pthreads.exp 7 Jan 2003 03:28:14 -0000 1.3 +++ mi1-pthreads.exp 1 Feb 2003 16:20:29 -0000 @@ -208,10 +208,8 @@ set srcfile "$testfile.c" set binfile "$objdir/$subdir/$testfile" set options [list debug incdir=$objdir] -if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] - != "" } { - gdb_suppress_entire_file \ - "Testcase compile failed, so all tests in this file will automatically fail." +if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } { + return -1 } mi_gdb_reinitialize_dir $srcdir/$subdir