Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Phil Edwards <phil@jaj.com>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: Nathanael Nerode <neroden@twcny.rr.com>,
	gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com,
	binutils@sources.redhat.com
Subject: Re: (toplevel patch) Use canonical names for target_subdir, build_subdir.
Date: Mon, 27 Jan 2003 14:56:00 -0000	[thread overview]
Message-ID: <20030127145629.GA31107@disaster.jaj.com> (raw)
In-Reply-To: <orptqkhygn.fsf@free.redhat.lsd.ic.unicamp.br>

On Sun, Jan 26, 2003 at 10:44:56AM -0200, Alexandre Oliva wrote:
> On Jan 26, 2003, Phil Edwards <phil@jaj.com> wrote:
> 
> > On Fri, Jan 24, 2003 at 02:50:21PM -0200, Alexandre Oliva wrote:
> >> On Jan 24, 2003, Nathanael Nerode <neroden@twcny.rr.com> wrote:
> >> 
> >> > Use the canonical build and target names for build_subdir and target_subdir.
> >> 
> >> Not ok.  athlon-linux-gnu is canonicalized to i686-linux-gnu, so we
> >> can't use the same directories for both of them.  (Consider building a
> >> compiler on athlon that must run on i686, or on the other way round).
> 
> > So, is this going to be reverted or not?  It's destroying the testsuite
> > results.
> 
> Please go ahead and revert it.  It must have gone in by mistake, since
> it was explicitly rejected.

Done as below.  Looking over the cvs log, I think Nathanael might have been
committed this by accident as part of reverting his rda stuff.  That would
explain why it was committed at the top level and not in the gcc directory.


2003-01-27  Phil Edwards  <pme@gcc.gnu.org>

	* configure.in:  Revert 24Jan change.
	* configure:  Regenerate.


Index: configure.in
===================================================================
RCS file: /cvs/gcc/gcc/configure.in,v
retrieving revision 1.217
diff -u -3 -p -r1.217 configure.in
--- configure.in	24 Jan 2003 00:39:39 -0000	1.217
+++ configure.in	27 Jan 2003 14:53:33 -0000
@@ -201,7 +201,7 @@ fi	
 
 # We always want to use the same name for this directory, so that dejagnu
 # can reliably find it.
-target_subdir=${target}
+target_subdir=${target_alias}
 
 if test ! -d ${target_subdir} ; then
   if mkdir ${target_subdir} ; then true
@@ -211,7 +211,8 @@ if test ! -d ${target_subdir} ; then
   fi
 fi
 
-build_subdir=build-${build}
+build_prefix=build-
+build_subdir=${build_prefix}${build_alias}
 
 if test x"${build_alias}" != x"${host}" ; then
   if test ! -d ${build_subdir} ; then


  reply	other threads:[~2003-01-27 14:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-24  3:41 Nathanael Nerode
2003-01-24 16:51 ` Alexandre Oliva
2003-01-24 18:32   ` Nathanael Nerode
2003-01-24 19:16     ` Alexandre Oliva
2003-01-26 12:22   ` Phil Edwards
2003-01-26 12:45     ` Alexandre Oliva
2003-01-27 14:56       ` Phil Edwards [this message]
2003-01-27 15:26         ` Phil Edwards
2003-01-25  0:56 ` Andreas Schwab
2003-01-25 21:27   ` Phil Edwards

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030127145629.GA31107@disaster.jaj.com \
    --to=phil@jaj.com \
    --cc=aoliva@redhat.com \
    --cc=binutils@sources.redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=neroden@twcny.rr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox