Re: [RFA] fix gdb/901 - attach to process running as service on Windows

[Christopher Faylor <cgf@redhat.com>]

On Thu, Dec 26, 2002 at 04:38:17PM +0400, Joel Brobecker wrote:
>The following patch fixes gdb/901. I am submitting it on behalf of
>Pascal Obry, who found the fix. No new regression on Windows XP.
>
>2002-12-26  J. Brobecker  <brobecker@gnat.com>
>
>        From Pascal Obry  <obry@act-europe.fr>
>        * win32-nat.c (SetPrivilege): New routine.
>        (Child_Attach): call SetPrivilege to correctly set child
>        privileges to be able to debug applications running as services.
>
>Ok to commit?

The theory is ok.  I'd already looked at the patch submitted with the
bug report but I question the legality of including source code directly
from Microsoft into gdb.

I asked our NT security expert (Corinna Vinschen) to take a look at
this.  We're looking at donating some code from cygwin to accomplish the
same thing.  Expect a patch when the holiday season is over.

So, to answer the question, "No, it's not ok to commit" but we should have
a fix for the problem relatively soon.

cgf