From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1355 invoked by alias); 26 Dec 2002 18:12:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1348 invoked from network); 26 Dec 2002 18:12:41 -0000 Received: from unknown (HELO redhat.com) (66.30.22.225) by 209.249.29.67 with SMTP; 26 Dec 2002 18:12:41 -0000 Received: by redhat.com (Postfix, from userid 201) id 8F2C21B955; Thu, 26 Dec 2002 13:12:32 -0500 (EST) Date: Thu, 26 Dec 2002 11:14:00 -0000 From: Christopher Faylor To: gdb-patches@sources.redhat.com Subject: Re: [RFA] fix gdb/901 - attach to process running as service on Windows Message-ID: <20021226181232.GC9340@redhat.com> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20021226123817.GR1137@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021226123817.GR1137@gnat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-12/txt/msg00683.txt.bz2 On Thu, Dec 26, 2002 at 04:38:17PM +0400, Joel Brobecker wrote: >The following patch fixes gdb/901. I am submitting it on behalf of >Pascal Obry, who found the fix. No new regression on Windows XP. > >2002-12-26 J. Brobecker > > From Pascal Obry > * win32-nat.c (SetPrivilege): New routine. > (Child_Attach): call SetPrivilege to correctly set child > privileges to be able to debug applications running as services. > >Ok to commit? The theory is ok. I'd already looked at the patch submitted with the bug report but I question the legality of including source code directly from Microsoft into gdb. I asked our NT security expert (Corinna Vinschen) to take a look at this. We're looking at donating some code from cygwin to accomplish the same thing. Expect a patch when the holiday season is over. So, to answer the question, "No, it's not ok to commit" but we should have a fix for the problem relatively soon. cgf