Re: [Jim Blandy <jimb@redhat.com>] RFA: Add tests for lookup_symbol_aux bug

[Michael Elizabeth Chastain <mec@shout.net>]

Jim Blandy submits:

  2002-10-04  Jim Blandy  <jimb@redhat.com>

	* gdb.c++/psmang.exp, gdb.c++/psmang1.cc, gdb.c++/psmang2.cc: New
	test.

This patch is approved, provided that you add one more comment.
(It seems kinda strange to exhort Jim Blandy, of all people, to write
more comments!)

It's already been approved by David Carlton so you could just commit
it and then consider my request.

My request is: in psmang.exp, mention whether you were testing with
dwarf-2 or stabs+ debugging format when you saw the bug happening.
This would be important if someone were trying to reproduce the bug.
(I saw the bug happening with both formats).

It feels a little strange to have a test which will PASS almost all the
time, even if gdb is broken.  I thought about it, and I decided that
it's okay with me.  A test which PASSes all the time actually takes up
very little human attention.  Also, there is plenty of information in
the test script, so someone could improve it with a patch later in the
future.  (For instance, we could add some maint commands to gdb to force
specific algorithmic paths in the symbol table reader so that test
scripts can exercise them).

Testing: I tested this on native i686-pc-linux-gnu, with:

  gdb     => 5.2.1, gdb_5_3-branch, HEAD
  gcc     => v2 and v3
  gformat => dwarf-2, stabs+

All configurations with gdb HEAD and gdb_5_3-branch gave these results.
So did gdb 5.2.1 with gcc v2:

  PASS: gdb.c++/psmang.exp: break s::method1
  PASS: gdb.c++/psmang.exp: break s::method2

The bug was fixed before gdb 5.3 was branched so gdb_5_3-branch is okay,
and presumably gdb 5.3 itself is too.

Configurations with gdb 5.2.1 and gcc v3 gave these results:

  FAIL: gdb.c++/psmang.exp: break s::method1
  PASS: gdb.c++/psmang.exp: break s::method2

This is all as expected, no surprises.

Michael C