From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31934 invoked by alias); 21 Dec 2002 06:59:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31927 invoked from network); 21 Dec 2002 06:59:49 -0000 Received: from unknown (HELO duracef.shout.net) (204.253.184.12) by 209.249.29.67 with SMTP; 21 Dec 2002 06:59:49 -0000 Received: (from mec@localhost) by duracef.shout.net (8.11.6/8.11.6) id gBL6xZJ31187; Sat, 21 Dec 2002 00:59:35 -0600 Date: Fri, 20 Dec 2002 23:11:00 -0000 From: Michael Elizabeth Chastain Message-Id: <200212210659.gBL6xZJ31187@duracef.shout.net> To: carlton@math.stanford.edu, fnasser@redhat.com, jimb@redhat.com Subject: Re: [Jim Blandy ] RFA: Add tests for lookup_symbol_aux bug Cc: gdb-patches@sources.redhat.com X-SW-Source: 2002-12/txt/msg00604.txt.bz2 Jim Blandy submits: 2002-10-04 Jim Blandy * gdb.c++/psmang.exp, gdb.c++/psmang1.cc, gdb.c++/psmang2.cc: New test. This patch is approved, provided that you add one more comment. (It seems kinda strange to exhort Jim Blandy, of all people, to write more comments!) It's already been approved by David Carlton so you could just commit it and then consider my request. My request is: in psmang.exp, mention whether you were testing with dwarf-2 or stabs+ debugging format when you saw the bug happening. This would be important if someone were trying to reproduce the bug. (I saw the bug happening with both formats). It feels a little strange to have a test which will PASS almost all the time, even if gdb is broken. I thought about it, and I decided that it's okay with me. A test which PASSes all the time actually takes up very little human attention. Also, there is plenty of information in the test script, so someone could improve it with a patch later in the future. (For instance, we could add some maint commands to gdb to force specific algorithmic paths in the symbol table reader so that test scripts can exercise them). Testing: I tested this on native i686-pc-linux-gnu, with: gdb => 5.2.1, gdb_5_3-branch, HEAD gcc => v2 and v3 gformat => dwarf-2, stabs+ All configurations with gdb HEAD and gdb_5_3-branch gave these results. So did gdb 5.2.1 with gcc v2: PASS: gdb.c++/psmang.exp: break s::method1 PASS: gdb.c++/psmang.exp: break s::method2 The bug was fixed before gdb 5.3 was branched so gdb_5_3-branch is okay, and presumably gdb 5.3 itself is too. Configurations with gdb 5.2.1 and gcc v3 gave these results: FAIL: gdb.c++/psmang.exp: break s::method1 PASS: gdb.c++/psmang.exp: break s::method2 This is all as expected, no surprises. Michael C