Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Michal Ludvig <mludvig@suse.cz>
Cc: GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] Artifical dwarf2 debug info
Date: Sun, 15 Dec 2002 11:03:00 -0000	[thread overview]
Message-ID: <20021215161924.GA2874@nevyn.them.org> (raw)
In-Reply-To: <3DFBD14C.7090501@suse.cz>

On Sun, Dec 15, 2002 at 01:48:12AM +0100, Michal Ludvig wrote:
> Hi all,
> this long patch provides a fix for a very annoying fact, that GDB on 
> x86-64 can't do backtraces from hand-optimized assembler functions (that 
> applies for example to glibc's memset, str*, etc as well as to syscall 
> wrappers).

Workaround, really - just for some particular functions...

> My approach to fix this behaviour is based on the fortunate fact, that 
> most of those affected glibc's functions don't touch the stack at all, 
> so creating an artifical FDE for them is easy.

Lucky.  We can use this to solve a similar problem on i386 but that
will require an actual FDE.

> Advantages of this approach are simplicity and cleanliness. There is no 
> need to "manually" fill in values in CFI's context structure - just 
> provide a valid, simple FDE and everything else will be done 
> automagically. This new FDE is of course joined to all other FDEs read 
> from the file before and is automatically used when needed again.
> 
> The patch is transparent to architectures that are not prepared to have 
> advantage of it and shouldn't hurt anything.

Great.  One big problem: gdbarch.h and gdbarch.c are generated files. 
Add this to gdbarch.sh instead, and regenerate them.  Also it needs
documentation, as Eli said.

It would be nice if there were routines in dwarf2cfi.[ch] for creating
FDEs instead of having hex in the tdep file but that doesn't really
bother me.  We can do that later when I need real FDEs.

> OK to commit to branch and mainline?

I do not believe this is appropriate for the branch, at least until
it's sat on mainline without causing problems for some time.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  parent reply	other threads:[~2002-12-15 16:18 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-14 17:31 Michal Ludvig
2002-12-14 22:53 ` Eli Zaretskii
2002-12-15 11:03 ` Daniel Jacobowitz [this message]
2002-12-16  7:28   ` Michal Ludvig
2002-12-16  7:49     ` Daniel Jacobowitz
2002-12-16  9:27       ` Michal Ludvig
2002-12-16  9:54         ` Daniel Jacobowitz
2002-12-16 10:38         ` Eli Zaretskii
2002-12-20  8:43           ` Michal Ludvig
2002-12-20 10:51             ` Eli Zaretskii
2002-12-16  9:25 ` Andrew Cagney
2002-12-16  9:40   ` Daniel Jacobowitz
2002-12-16 10:04     ` Andrew Cagney
2002-12-16 10:17       ` Daniel Jacobowitz
2002-12-16 10:56         ` Andrew Cagney
2002-12-16 11:13           ` Daniel Jacobowitz
2002-12-16 11:34             ` Andrew Cagney
2002-12-16 11:57               ` Daniel Jacobowitz
2002-12-16 12:10                 ` Andrew Cagney
2002-12-16 12:42                   ` Daniel Jacobowitz
2002-12-17  6:23                     ` Michal Ludvig
2002-12-17  6:28                       ` Andrew Cagney
2002-12-17  8:42                         ` Daniel Jacobowitz
2002-12-18  4:39                           ` Andrew Cagney
2002-12-18 10:05                             ` Daniel Jacobowitz
2003-01-02 20:54                               ` Andrew Cagney
2003-01-02 21:19                                 ` Daniel Jacobowitz
2003-01-02 23:05                                   ` Andrew Cagney
2003-01-02 23:27                                     ` Daniel Jacobowitz
2003-01-03  0:28                                       ` Andrew Cagney
2002-12-16  9:46   ` Michal Ludvig
2002-12-16  9:57     ` Andrew Cagney
2002-12-16 10:01       ` Michal Ludvig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021215161924.GA2874@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mludvig@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox