Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* Patch: gdb/hppa-tdep.c fix compilation.
@ 2002-12-15  8:05 rdbrown
  2002-12-16  8:25 ` Joel Brobecker
  0 siblings, 1 reply; 2+ messages in thread
From: rdbrown @ 2002-12-15  8:05 UTC (permalink / raw)
  To: gdb-patches

Fix compilation of hppa-tdep.c and remove implicit declarations.

1213/gdb/hppa-tdep.c: In function `hppa_pop_frame':
1213/gdb/hppa-tdep.c:1607:\
 incompatible type for argument 2 of `set_momentary_breakpoint'
1213/gdb/hppa-tdep.c: In function `hppa_fix_call_dummy':
1213/gdb/hppa-tdep.c:2296: warning:\
 implicit declaration of function `som_solib_get_solib_by_pc'
1213/gdb/hppa-tdep.c: In function `hppa_prepare_to_proceed':
1213/gdb/hppa-tdep.c:4640: warning:\
 implicit declaration of function `hppa_switched_threads'

2002-12-15  Rodney Brown  <rbrown64@csc.com.au>

	* hppa-tdep.c: Prototype som_solib_get_solib_by_pc,
		hppa_switched_threads.
	(hppa_pop_frame): null_frame_id in set_momemtary_breakpoint.

--- /home/rdb/gdb+dejagnu-20021208/gdb/hppa-tdep.c	2002-12-15 17:31:09.000000000 +1100
+++ ./hppa-tdep.c	2002-12-15 14:29:21.000000000 +1100
@@ -146,7 +146,9 @@ int hppa_cannot_store_register (int regn
 CORE_ADDR hppa_frame_args_address (struct frame_info *fi);
 CORE_ADDR hppa_frame_locals_address (struct frame_info *fi);
 CORE_ADDR hppa_smash_text_address (CORE_ADDR addr);
+pid_t hppa_switched_threads (pid_t pid);
 int hppa_coerce_float_to_double (struct type *formal, struct type *actual);
+CORE_ADDR som_solib_get_solib_by_pc (CORE_ADDR addr);
 
 typedef struct
   {
@@ -1604,7 +1606,7 @@ hppa_pop_frame (void)
          for "return_command" will print the frame we returned to.  */
       sal = find_pc_line (target_pc, 0);
       sal.pc = target_pc;
-      breakpoint = set_momentary_breakpoint (sal, NULL, bp_finish);
+      breakpoint = set_momentary_breakpoint (sal, null_frame_id, bp_finish);
       breakpoint->silent = 1;
 
       /* So we can clean things up.  */


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Patch: gdb/hppa-tdep.c fix compilation.
  2002-12-15  8:05 Patch: gdb/hppa-tdep.c fix compilation rdbrown
@ 2002-12-16  8:25 ` Joel Brobecker
  0 siblings, 0 replies; 2+ messages in thread
From: Joel Brobecker @ 2002-12-16  8:25 UTC (permalink / raw)
  To: rdbrown; +Cc: gdb-patches

> 2002-12-15  Rodney Brown  <rbrown64@csc.com.au>
> 
> 	* hppa-tdep.c: Prototype som_solib_get_solib_by_pc,
> 		hppa_switched_threads.

Thanks for catching this, but I'd rather not add the prototype for
som_solib_get_solib_by_pc, as this function does not exist when the
target is hppa64-*-hpux*... Eventually, I hope to allow both the SOM and
ELF version of this function to coexist in the same GDB executable,
but in the meantime I'd prefer if it wasn't added. (this is just my
own opinion)

> 	(hppa_pop_frame): null_frame_id in set_momemtary_breakpoint.

I actually fixed this one on Dec 13th :).

-- 
Joel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-12-16 15:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-12-15  8:05 Patch: gdb/hppa-tdep.c fix compilation rdbrown
2002-12-16  8:25 ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox