From: ac131313@redhat.com (Andrew Cagney)
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Get rid of DEPRECATED_PC_IN_CALL_DUMMY in i386-tdep.c
Date: Wed, 11 Dec 2002 09:38:00 -0000 [thread overview]
Message-ID: <20021211145557.3DF383C17@localhost.redhat.com> (raw)
In-Reply-To: <200212111438.gBBEcRrl037953@elgar.kettenis.dyndns.org> "from Mark Kettenis at Dec 11, 2002 03:38:27 pm"
Mark,
> @@ -566,7 +567,7 @@ i386_sigtramp_saved_sp (struct frame_inf
> static CORE_ADDR
> i386_frame_saved_pc (struct frame_info *frame)
> {
> - if (DEPRECATED_PC_IN_CALL_DUMMY (frame->pc, 0, 0))
> + if (pc_in_dummy_frame (frame->pc))
> {
> ULONGEST pc;
>
What happens if you simply delete the above? This function should now
only be called on non-dummy frames.
> @@ -509,7 +510,7 @@ i386_frameless_signal_p (struct frame_in
> static CORE_ADDR
> i386_frame_chain (struct frame_info *frame)
> {
> - if (DEPRECATED_PC_IN_CALL_DUMMY (frame->pc, 0, 0))
> + if (pc_in_dummy_frame (frame->pc))
> return frame->frame;
>
> if (get_frame_type (frame) == SIGTRAMP_FRAME
This test hasn't quite been eliminated. I need to add
frame_id_unwind() to the frame object.
Andrew
next prev parent reply other threads:[~2002-12-11 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-11 6:56 Mark Kettenis
2002-12-11 9:38 ` Andrew Cagney [this message]
2002-12-12 3:06 ` Richard Earnshaw
2002-12-12 16:19 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021211145557.3DF383C17@localhost.redhat.com \
--to=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox