From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17468 invoked by alias); 11 Dec 2002 14:56:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17461 invoked from network); 11 Dec 2002 14:56:07 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 11 Dec 2002 14:56:07 -0000 Received: by localhost.redhat.com (Postfix, from userid 1008) id 3DF383C17; Wed, 11 Dec 2002 09:55:57 -0500 (EST) Subject: Re: [PATCH] Get rid of DEPRECATED_PC_IN_CALL_DUMMY in i386-tdep.c In-Reply-To: <200212111438.gBBEcRrl037953@elgar.kettenis.dyndns.org> "from Mark Kettenis at Dec 11, 2002 03:38:27 pm" To: Mark Kettenis Date: Wed, 11 Dec 2002 09:38:00 -0000 Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Message-Id: <20021211145557.3DF383C17@localhost.redhat.com> From: ac131313@redhat.com (Andrew Cagney) X-SW-Source: 2002-12/txt/msg00358.txt.bz2 Mark, > @@ -566,7 +567,7 @@ i386_sigtramp_saved_sp (struct frame_inf > static CORE_ADDR > i386_frame_saved_pc (struct frame_info *frame) > { > - if (DEPRECATED_PC_IN_CALL_DUMMY (frame->pc, 0, 0)) > + if (pc_in_dummy_frame (frame->pc)) > { > ULONGEST pc; > What happens if you simply delete the above? This function should now only be called on non-dummy frames. > @@ -509,7 +510,7 @@ i386_frameless_signal_p (struct frame_in > static CORE_ADDR > i386_frame_chain (struct frame_info *frame) > { > - if (DEPRECATED_PC_IN_CALL_DUMMY (frame->pc, 0, 0)) > + if (pc_in_dummy_frame (frame->pc)) > return frame->frame; > > if (get_frame_type (frame) == SIGTRAMP_FRAME This test hasn't quite been eliminated. I need to add frame_id_unwind() to the frame object. Andrew