Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* Re: (toplevel patch) Configure in Makefile, version 3.
@ 2002-12-05 16:54 Nathanael Nerode
  0 siblings, 0 replies; 11+ messages in thread
From: Nathanael Nerode @ 2002-12-05 16:54 UTC (permalink / raw)
  To: ac131313, gdb-patches

> Ok, now that I've recovered from my `pleasant suprise' :-) I'm finding 
>that, given a build that barfs in GDB, it tries to re-configure BFD 
>when 
>re-made.
>
> It's being run with `gmake -k -j 2'. Anyone else noticed this?

Not me.

Have you got it working when the build doesn't crash in gdb?...
I've done oodles of builds with the current versions of the files, but 
I'm sure there are builds I haven't tried. :-/

The only reasons it should try to reconfigure BFD are:
* bfd/Makefile was changed (or 'touch'ed) by something
* libiberty/Makefile was changed (or 'touch'ed) by something
* config.status at the top level was changed (or 'touch'ed) by something

I can't imagine why either of those things would happen.

Is it really a problem, anyway?  BFD is reconfigured with the same 
arguments it was configured with the previous time...

It *will* try to rebuild BFD.  That is correct.  BFD's Makefile should 
be clever enough to do nothing in this case, though it might not be.

Hmm.  When GNU make runs BFD's Makefile, maybe BFD's Makefile decides 
that it's out of date?  I haven't poked BFD's Makefile enough.

Can you figure out which level of Make is trying to rebuild BFD's 
Makefile?

--Nathanael


^ permalink raw reply	[flat|nested] 11+ messages in thread
* (toplevel patch) Configure in Makefile, version 3.
@ 2002-12-04 18:27 Nathanael Nerode
  2002-12-05 12:10 ` Andrew Cagney
  0 siblings, 1 reply; 11+ messages in thread
From: Nathanael Nerode @ 2002-12-04 18:27 UTC (permalink / raw)
  To: gcc-patches, gdb-patches, dj, binutils

Forget the last one.  I came up with a better (temporarily, anyway)
 solution.  *sigh*

Index: Makefile.tpl
===================================================================
RCS file: /cvs/gcc/gcc/Makefile.tpl,v
retrieving revision 1.5.2.21
diff -u -r1.5.2.21 Makefile.tpl
--- Makefile.tpl	4 Dec 2002 01:41:48 -0000	1.5.2.21
+++ Makefile.tpl	5 Dec 2002 02:21:12 -0000
@@ -530,14 +530,8 @@
 
 GCC_FLAGS_TO_PASS = $(BASE_FLAGS_TO_PASS) $(EXTRA_GCC_FLAGS)
 
-# This is a list of the configure targets for all of the modules which
-# are compiled using the target tools.
-CONFIGURE_TARGET_MODULES =[+
-    FOR target_modules +] \
-	configure-target-[+module+][+
-    ENDFOR target_modules +]
-
-configure-target: $(CONFIGURE_TARGET_MODULES)
+configure-host: @configure_host_modules@
+configure-target: @configure_target_modules@
 
 # This is a list of the targets for which we can do a clean-{target}.
 CLEAN_MODULES =[+
@@ -566,6 +560,7 @@
 	@all_host_modules@ \
 	@all_target_modules@
 
+all-host: @all_host_modules@
 all-target: @all_target_modules@
 
 # Do a target for all the subdirectories.  A ``make do-X'' will do a
@@ -910,7 +905,7 @@
 
 .PHONY: all-[+module+] maybe-all-[+module+]
 maybe-all-[+module+]:
-all-[+module+]:
+all-[+module+]: configure-[+module+]
 	@r=`${PWD}`; export r; \
 	  s=`cd $(srcdir); ${PWD}`; export s; \
 	  $(SET_LIB_PATH) \
@@ -1139,16 +1134,19 @@
 	  $(HOST_CONFIGARGS) $${srcdiroption} \
 	  || exit 1
 
+# Don't remake gcc if it's already been made by 'bootstrap'; that causes
+# nothing but trouble.  This wart will be fixed eventually by moving
+# the bootstrap behavior to this file.
 .PHONY: all-gcc maybe-all-gcc
 maybe-all-gcc:
-all-gcc:
-	@if [ -f ./gcc/Makefile ] ; then \
+all-gcc: configure-gcc
+	@if [ -f gcc/xgcc ] ; then \
+	  exit 0 ; \
+	else \
 	  r=`${PWD}`; export r; \
 	  s=`cd $(srcdir); ${PWD}`; export s; \
 	  $(SET_LIB_PATH) \
 	  (cd gcc; $(MAKE) $(GCC_FLAGS_TO_PASS) all); \
-	else \
-	  true; \
 	fi
 
 # Building GCC uses some tools for rebuilding "source" files
@@ -1162,7 +1160,7 @@
 # in parallel.
 #
 .PHONY: bootstrap bootstrap-lean bootstrap2 bootstrap2-lean bootstrap3 bootstrap3-lean bootstrap4 bootstrap4-lean bubblestrap quickstrap cleanstrap restrap
-bootstrap bootstrap-lean bootstrap2 bootstrap2-lean bootstrap3 bootstrap3-lean bootstrap4 bootstrap4-lean bubblestrap quickstrap cleanstrap restrap: all-bootstrap
+bootstrap bootstrap-lean bootstrap2 bootstrap2-lean bootstrap3 bootstrap3-lean bootstrap4 bootstrap4-lean bubblestrap quickstrap cleanstrap restrap: all-bootstrap configure-gcc
 	@r=`${PWD}`; export r; \
 	s=`cd $(srcdir); ${PWD}`; export s; \
 	$(SET_LIB_PATH) \


^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2002-12-06  0:45 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-12-05 16:54 (toplevel patch) Configure in Makefile, version 3 Nathanael Nerode
  -- strict thread matches above, loose matches on Subject: below --
2002-12-04 18:27 Nathanael Nerode
2002-12-05 12:10 ` Andrew Cagney
2002-12-05 12:15   ` DJ Delorie
2002-12-05 12:20     ` Andrew Cagney
2002-12-05 12:22       ` DJ Delorie
2002-12-05 12:30       ` Andrew Cagney
2002-12-05 12:36         ` Daniel Jacobowitz
2002-12-05 12:48           ` Andrew Cagney
2002-12-05 12:51             ` DJ Delorie
2002-12-05 15:15     ` Andrew Cagney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox