From: Josh Martin <jdmartin@atoae450.abq.sc.philips.com>
To: Josh.Martin@abq.sc.philips.com, gdb-patches@sources.redhat.com,
kevinb@redhat.com
Subject: Re: [PATCH]: gdb/769 - segv fault on "info shared" on GDB 5.2.1 HPUX64 11.00
Date: Tue, 26 Nov 2002 15:03:00 -0000 [thread overview]
Message-ID: <200211262303.gAQN3Bq29572@atoae450.abq.sc.philips.com> (raw)
I was not familiar with how gdb called errors, so I just looked at similar code
from that source file. If what I used was not the correct method then by all
means change the patch, or point me to the definition of error() so I can change
it appropriately.
- Josh Martin
> Date: Mon, 25 Nov 2002 16:08:20 -0700
> From: Kevin Buettner <kevinb@redhat.com>
> To: Josh Martin <Josh.Martin@abq.sc.philips.com>,
gdb-patches@sources.redhat.com
> Subject: Re: [PATCH]: gdb/769 - segv fault on "info shared" on GDB 5.2.1
HPUX64 11.00
> MIME-Version: 1.0
>
> On Oct 9, 5:42pm, Josh Martin wrote:
>
> > 2002-09-28 Josh Martin <timeslice@iname.com>
> >
> > * solib.c (info_sharedlibrary_command): Added catch for potential
> > dereference of NULL pointer (current_target_so_ops).
> > Fix PR gdb/769.
>
> Josh,
>
> Your patch looks reasonable. I think I'd prefer to see a call to error()
> instead of printf_unfiltered() though:
>
> > > + printf_unfiltered("Shared library info is not yet implemented on
this "
> > > + "platform\n");
>
> Sorry for taking so long on this.
>
> Kevin
next reply other threads:[~2002-11-26 23:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-26 15:03 Josh Martin [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-12-09 18:56 Josh Martin
2002-10-09 16:43 Josh Martin
2002-11-25 15:08 ` Kevin Buettner
2002-12-05 16:56 ` Kevin Buettner
2002-09-28 10:23 Josh Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200211262303.gAQN3Bq29572@atoae450.abq.sc.philips.com \
--to=jdmartin@atoae450.abq.sc.philips.com \
--cc=Josh.Martin@abq.sc.philips.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox