From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25873 invoked by alias); 26 Nov 2002 23:03:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25861 invoked from network); 26 Nov 2002 23:03:52 -0000 Received: from unknown (HELO gw-us1.philips.com) (63.114.235.94) by sources.redhat.com with SMTP; 26 Nov 2002 23:03:52 -0000 Received: from smtpscan-us1.philips.com (unknown [167.81.233.25]) by gw-us1.philips.com (Postfix) with ESMTP id C9C293D7F9; Tue, 26 Nov 2002 17:03:20 -0600 (CST) Received: from smtprelay-us1.philips.com (localhost [127.0.0.1]) by smtpscan-us1.philips.com (8.9.3/8.8.5-1.2.2m-19990317) with ESMTP id RAA10936; Tue, 26 Nov 2002 17:03:20 -0600 (CST) Received: from smtphub.abq.sc.philips.com (smtphub.abq.sc.philips.com [130.140.3.9]) by smtprelay-us1.philips.com (8.9.3/8.8.5-1.2.2m-19990317) with ESMTP id RAA17925; Tue, 26 Nov 2002 17:03:18 -0600 (CST) Received: from atoae450.abq.sc.philips.com (atoae450.abq.sc.philips.com [130.140.5.8]) by smtphub.abq.sc.philips.com (8.8.5/8.8.5) with ESMTP id QAA25911; Tue, 26 Nov 2002 16:04:49 -0700 (MST) Received: from abqn42.abq.sc.philips.com (abqn42 [130.140.5.42]) by atoae450.abq.sc.philips.com (8.11.6+Sun/8.11.6) with SMTP id gAQN3Bq29572; Tue, 26 Nov 2002 16:03:11 -0700 (MST) Message-Id: <200211262303.gAQN3Bq29572@atoae450.abq.sc.philips.com> Date: Tue, 26 Nov 2002 15:03:00 -0000 From: Josh Martin Reply-To: Josh Martin Subject: Re: [PATCH]: gdb/769 - segv fault on "info shared" on GDB 5.2.1 HPUX64 11.00 To: Josh.Martin@abq.sc.philips.com, gdb-patches@sources.redhat.com, kevinb@redhat.com MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Content-MD5: X28Rb6aevRQ869dVB+F8NQ== X-SW-Source: 2002-11/txt/msg00667.txt.bz2 I was not familiar with how gdb called errors, so I just looked at similar code from that source file. If what I used was not the correct method then by all means change the patch, or point me to the definition of error() so I can change it appropriately. - Josh Martin > Date: Mon, 25 Nov 2002 16:08:20 -0700 > From: Kevin Buettner > To: Josh Martin , gdb-patches@sources.redhat.com > Subject: Re: [PATCH]: gdb/769 - segv fault on "info shared" on GDB 5.2.1 HPUX64 11.00 > MIME-Version: 1.0 > > On Oct 9, 5:42pm, Josh Martin wrote: > > > 2002-09-28 Josh Martin > > > > * solib.c (info_sharedlibrary_command): Added catch for potential > > dereference of NULL pointer (current_target_so_ops). > > Fix PR gdb/769. > > Josh, > > Your patch looks reasonable. I think I'd prefer to see a call to error() > instead of printf_unfiltered() though: > > > > + printf_unfiltered("Shared library info is not yet implemented on this " > > > + "platform\n"); > > Sorry for taking so long on this. > > Kevin