From: Richard Earnshaw <rearnsha@arm.com>
To: Nick Clifton <nickc@redhat.com>
Cc: newlib@sources.redhat.com, gdb-patches@sources.redhat.com,
Richard.Earnshaw@arm.com
Subject: Re: ARM crt0.o: Add NULL to end of argv[]
Date: Mon, 18 Nov 2002 07:53:00 -0000 [thread overview]
Message-ID: <200211181552.gAIFqmt05403@pc960.cambridge.arm.com> (raw)
In-Reply-To: Your message of "Mon, 18 Nov 2002 15:48:42 GMT." <200211181548.gAIFmh216204@pc960.cambridge.arm.com>
>
> > + /* Push a NULL argument onto the end of the list. */
> > + mov r2, #0
> > + #ifdef __thumb__
> > + push {r2}
> > + #else
> > + stmfd sp!, {r1}
> > + #endif
> > #endif
>
> That can't be right. The arm and thumb code push different registers!!!!
>
> R.
>
And even if you change that I'm not convinced. Surely you need to push
this extra value *before* you reverse the list. Otherwise the first
argument will be null, not the last.
R.
next prev parent reply other threads:[~2002-11-18 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-18 7:20 Nick Clifton
2002-11-18 7:50 ` Richard Earnshaw
2002-11-18 7:53 ` Richard Earnshaw [this message]
2002-11-18 8:30 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200211181552.gAIFqmt05403@pc960.cambridge.arm.com \
--to=rearnsha@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gdb-patches@sources.redhat.com \
--cc=newlib@sources.redhat.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox