From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-20202-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 12788 invoked by alias); 18 Nov 2002 15:53:50 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 12774 invoked from network); 18 Nov 2002 15:53:47 -0000
Received: from unknown (HELO fw-cam.cambridge.arm.com) (193.131.176.3)
  by sources.redhat.com with SMTP; 18 Nov 2002 15:53:47 -0000
Received: by fw-cam.cambridge.arm.com; id PAA02164; Mon, 18 Nov 2002 15:53:45 GMT
Received: from unknown(172.16.1.2) by fw-cam.cambridge.arm.com via smap (V5.5)
	id xma001088; Mon, 18 Nov 02 15:52:49 GMT
Received: from pc960.cambridge.arm.com (pc960.cambridge.arm.com [10.1.205.4])
	by cam-admin0.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id PAA02595;
	Mon, 18 Nov 2002 15:52:48 GMT
Received: from pc960.cambridge.arm.com (rearnsha@localhost)
	by pc960.cambridge.arm.com (8.11.6/8.9.3) with ESMTP id gAIFqmt05403;
	Mon, 18 Nov 2002 15:52:48 GMT
Message-Id: <200211181552.gAIFqmt05403@pc960.cambridge.arm.com>
X-Authentication-Warning: pc960.cambridge.arm.com: rearnsha owned process doing -bs
To: Nick Clifton <nickc@redhat.com>
cc: newlib@sources.redhat.com, gdb-patches@sources.redhat.com,
        Richard.Earnshaw@arm.com
Reply-To: Richard.Earnshaw@arm.com
Organization: ARM Ltd.
X-Telephone: +44 1223 400569 (direct+voicemail), +44 1223 400400 (switchbd)
X-Fax: +44 1223 400410
X-Address: ARM Ltd., 110 Fulbourn Road, Cherry Hinton, Cambridge CB1 9NJ.
Subject: Re: ARM crt0.o: Add NULL to end of argv[] 
In-reply-to: Your message of "Mon, 18 Nov 2002 15:48:42 GMT."
             <200211181548.gAIFmh216204@pc960.cambridge.arm.com> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Mon, 18 Nov 2002 07:53:00 -0000
From: Richard Earnshaw <rearnsha@arm.com>
X-SW-Source: 2002-11/txt/msg00458.txt.bz2

> 
> > + 	/* Push a NULL argument onto the end of the list.  */
> > + 	mov	r2, #0
> > + #ifdef __thumb__
> > + 	push	{r2}
> > + #else
> > + 	stmfd	sp!, {r1}
> > + #endif
> >   #endif
> 
> That can't be right.  The arm and thumb code push different registers!!!!
> 
> R.
> 

And even if you change that I'm not convinced.  Surely you need to push 
this extra value *before* you reverse the list.  Otherwise the first 
argument will be null, not the last.

R.