Re: [rfc] clean up linespec.c

[Daniel Jacobowitz <drow@mvista.com>]

On Wed, Nov 06, 2002 at 05:16:24PM -0800, David Carlton wrote:
> For various reasons, I've been cleaning up linespec.c on a branch; I
> find the resulting version of linespec.c enough more
> legible/maintainable that I suspect I'm not the only person who would
> find it useful.
> 
> The cleanups consist almost entirely of refactoring rather than
> changing the behavior: I've broken up large functions into multiple
> small functions, renamed variable names to make their use clearer, and
> the like.  Since I was already touching so much of the code, I also
> fixed up stylistic niceties: using NULL where appropriate, deleting
> unnecessary casts, fixing comments to end in a period followed by two
> spaces, and stuff like that.

Great.  When you're done with this I may spend some time on it; I have
this pipe-dream of (changing the function's behavior slightly and)
simplifying it by adding an actual parser.  I think it could be done.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer