From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19898 invoked by alias); 7 Nov 2002 01:40:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19891 invoked from network); 7 Nov 2002 01:40:57 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 7 Nov 2002 01:40:57 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 189dXf-00008o-00 for ; Wed, 06 Nov 2002 21:41:16 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 189bgA-0004YQ-00 for ; Wed, 06 Nov 2002 20:41:54 -0500 Date: Wed, 06 Nov 2002 17:40:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [rfc] clean up linespec.c Message-ID: <20021107014154.GA17037@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2002-11/txt/msg00161.txt.bz2 On Wed, Nov 06, 2002 at 05:16:24PM -0800, David Carlton wrote: > For various reasons, I've been cleaning up linespec.c on a branch; I > find the resulting version of linespec.c enough more > legible/maintainable that I suspect I'm not the only person who would > find it useful. > > The cleanups consist almost entirely of refactoring rather than > changing the behavior: I've broken up large functions into multiple > small functions, renamed variable names to make their use clearer, and > the like. Since I was already touching so much of the code, I also > fixed up stylistic niceties: using NULL where appropriate, deleting > unnecessary casts, fixing comments to end in a period followed by two > spaces, and stuff like that. Great. When you're done with this I may spend some time on it; I have this pipe-dream of (changing the function's behavior slightly and) simplifying it by adding an actual parser. I think it could be done. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer