[RFA/testsuite] Update selftest.exp

[RFA/testsuite] Update selftest.exp

[Daniel Jacobowitz]

Are others seeing this failure?  If not, I'm not sure why not.  There is no
main in "main.c" any more.  It's in "gdb.c" now.

The "read" was bogus, too.  It was supposed to match a read syscall; what it
was actually matching was some debugging info that said "readline/".  We
call poll for the event loop nowadays.

Is this patch OK?  Should I also match "gdbtk-main.c" [I don't know if this
part of the testsuite is ever run on the insight binary]?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

2002-10-21  Daniel Jacobowitz  <drow@mvista.com>

	* gdb.base/selftest.exp: Update for current gdb.

Index: testsuite/gdb.base/selftest.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/selftest.exp,v
retrieving revision 1.4
diff -u -p -r1.4 selftest.exp
--- testsuite/gdb.base/selftest.exp	22 Jun 2002 22:19:37 -0000	1.4
+++ testsuite/gdb.base/selftest.exp	13 Oct 2002 22:55:02 -0000
@@ -392,7 +392,7 @@ GDB.*Copyright \[0-9\]+ Free Software Fo
     set description "backtrace through signal handler"
     send_gdb "backtrace\n"
     gdb_expect {
-	-re "#0.*read.*in main \\(.*\\) at .*main\\.c.*$gdb_prompt $" {
+	-re "#0.*(read|poll).*in main \\(.*\\) at .*gdb\\.c.*$gdb_prompt $" {
 	    pass "$description"
 	}
 	-re ".*$gdb_prompt $" {

Re: [RFA/testsuite] Update selftest.exp

[Keith Seitz]

On Mon, 21 Oct 2002, Daniel Jacobowitz wrote:

> Are others seeing this failure?  If not, I'm not sure why not.  There is no
> main in "main.c" any more.  It's in "gdb.c" now.

Yes, I see this failure, too.

> Should I also match "gdbtk-main.c" [I don't know if this
> part of the testsuite is ever run on the insight binary]?

I don't think it is necessary unless there is a way to use the insight 
executable with testing. Right now, I believe the testsuite will always 
run "gdb" and there is no way to change this (tool-exec doesn't seem to 
fit the bill).

Keith

Re: [RFA/testsuite] Update selftest.exp

[Daniel Jacobowitz]

On Mon, Oct 21, 2002 at 10:07:30PM -0400, Daniel Jacobowitz wrote:
> Are others seeing this failure?  If not, I'm not sure why not.  There is no
> main in "main.c" any more.  It's in "gdb.c" now.
> 
> The "read" was bogus, too.  It was supposed to match a read syscall; what it
> was actually matching was some debugging info that said "readline/".  We
> call poll for the event loop nowadays.
> 
> Is this patch OK?  Should I also match "gdbtk-main.c" [I don't know if this
> part of the testsuite is ever run on the insight binary]?

Ping.  Keith confirmed that I'm OK on the insight side.

> 
> -- 
> Daniel Jacobowitz
> MontaVista Software                         Debian GNU/Linux Developer
> 
> 2002-10-21  Daniel Jacobowitz  <drow@mvista.com>
> 
> 	* gdb.base/selftest.exp: Update for current gdb.
> 
> Index: testsuite/gdb.base/selftest.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/selftest.exp,v
> retrieving revision 1.4
> diff -u -p -r1.4 selftest.exp
> --- testsuite/gdb.base/selftest.exp	22 Jun 2002 22:19:37 -0000	1.4
> +++ testsuite/gdb.base/selftest.exp	13 Oct 2002 22:55:02 -0000
> @@ -392,7 +392,7 @@ GDB.*Copyright \[0-9\]+ Free Software Fo
>      set description "backtrace through signal handler"
>      send_gdb "backtrace\n"
>      gdb_expect {
> -	-re "#0.*read.*in main \\(.*\\) at .*main\\.c.*$gdb_prompt $" {
> +	-re "#0.*(read|poll).*in main \\(.*\\) at .*gdb\\.c.*$gdb_prompt $" {
>  	    pass "$description"
>  	}
>  	-re ".*$gdb_prompt $" {
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [RFA/testsuite] Update selftest.exp

[Daniel Jacobowitz]

This is now PR gdb/862.  Fernando?

On Tue, Nov 05, 2002 at 04:45:22PM -0500, Daniel Jacobowitz wrote:
> On Mon, Oct 21, 2002 at 10:07:30PM -0400, Daniel Jacobowitz wrote:
> > Are others seeing this failure?  If not, I'm not sure why not.  There is no
> > main in "main.c" any more.  It's in "gdb.c" now.
> > 
> > The "read" was bogus, too.  It was supposed to match a read syscall; what it
> > was actually matching was some debugging info that said "readline/".  We
> > call poll for the event loop nowadays.
> > 
> > Is this patch OK?  Should I also match "gdbtk-main.c" [I don't know if this
> > part of the testsuite is ever run on the insight binary]?
> 
> Ping.  Keith confirmed that I'm OK on the insight side.
> 
> > 
> > -- 
> > Daniel Jacobowitz
> > MontaVista Software                         Debian GNU/Linux Developer
> > 
> > 2002-10-21  Daniel Jacobowitz  <drow@mvista.com>
> > 
> > 	* gdb.base/selftest.exp: Update for current gdb.
> > 
> > Index: testsuite/gdb.base/selftest.exp
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/selftest.exp,v
> > retrieving revision 1.4
> > diff -u -p -r1.4 selftest.exp
> > --- testsuite/gdb.base/selftest.exp	22 Jun 2002 22:19:37 -0000	1.4
> > +++ testsuite/gdb.base/selftest.exp	13 Oct 2002 22:55:02 -0000
> > @@ -392,7 +392,7 @@ GDB.*Copyright \[0-9\]+ Free Software Fo
> >      set description "backtrace through signal handler"
> >      send_gdb "backtrace\n"
> >      gdb_expect {
> > -	-re "#0.*read.*in main \\(.*\\) at .*main\\.c.*$gdb_prompt $" {
> > +	-re "#0.*(read|poll).*in main \\(.*\\) at .*gdb\\.c.*$gdb_prompt $" {
> >  	    pass "$description"
> >  	}
> >  	-re ".*$gdb_prompt $" {
> > 
> 
> -- 
> Daniel Jacobowitz
> MontaVista Software                         Debian GNU/Linux Developer
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [RFA/testsuite] Update selftest.exp

[Fernando Nasser]

OK with me as well.  I guess we just forgot to update this.

Thanks!

Fernando

Daniel Jacobowitz wrote:
> On Mon, Oct 21, 2002 at 10:07:30PM -0400, Daniel Jacobowitz wrote:
> 
>>Are others seeing this failure?  If not, I'm not sure why not.  There is no
>>main in "main.c" any more.  It's in "gdb.c" now.
>>
>>The "read" was bogus, too.  It was supposed to match a read syscall; what it
>>was actually matching was some debugging info that said "readline/".  We
>>call poll for the event loop nowadays.
>>
>>Is this patch OK?  Should I also match "gdbtk-main.c" [I don't know if this
>>part of the testsuite is ever run on the insight binary]?
> 
> 
> Ping.  Keith confirmed that I'm OK on the insight side.
> 
> 
>>-- 
>>Daniel Jacobowitz
>>MontaVista Software                         Debian GNU/Linux Developer
>>
>>2002-10-21  Daniel Jacobowitz  <drow@mvista.com>
>>
>>	* gdb.base/selftest.exp: Update for current gdb.
>>
>>Index: testsuite/gdb.base/selftest.exp
>>===================================================================
>>RCS file: /cvs/src/src/gdb/testsuite/gdb.base/selftest.exp,v
>>retrieving revision 1.4
>>diff -u -p -r1.4 selftest.exp
>>--- testsuite/gdb.base/selftest.exp	22 Jun 2002 22:19:37 -0000	1.4
>>+++ testsuite/gdb.base/selftest.exp	13 Oct 2002 22:55:02 -0000
>>@@ -392,7 +392,7 @@ GDB.*Copyright \[0-9\]+ Free Software Fo
>>     set description "backtrace through signal handler"
>>     send_gdb "backtrace\n"
>>     gdb_expect {
>>-	-re "#0.*read.*in main \\(.*\\) at .*main\\.c.*$gdb_prompt $" {
>>+	-re "#0.*(read|poll).*in main \\(.*\\) at .*gdb\\.c.*$gdb_prompt $" {
>> 	    pass "$description"
>> 	}
>> 	-re ".*$gdb_prompt $" {
>>
> 
> 


-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9

Re: [RFA/testsuite] Update selftest.exp

[Michael Elizabeth Chastain]

Proofread.  Remember to update the copyright year on the first line.
Other than that, perfect.

Tested on 132 configurations:

  target   = native
  host     = i686-pc-linux-gnu%rh-8
  gdb      = gdb_5_3-branch%20021125, HEAD%20021125
  gcc      = 2.95.3, 3.0.4, 3.1, 3.1.1, 3.2, 3.2-7-rh, 3.2.1, gcc-3_2-branch%20021125, HEAD%20021125
  binutils = 2.13.1, 2.13.90.0.2-rh, binutils-2_13-branch%20021125, HEAD%20021125
  glibc    = 2.2.93-5-rh
  gformat  = dwarf2, stabs+

Fixes the bug in all configurations.  No regressions introduced.

Recommended for approval on mainline.  After commit to mainline, wait
one week, then recommended for approval on 5.3 branch if no problems arise.
Not a showstopper for 5.3 release.

Michael C

> > 2002-10-21  Daniel Jacobowitz  <drow@mvista.com>
> > 
> > 	* gdb.base/selftest.exp: Update for current gdb.
> > 
> > Index: testsuite/gdb.base/selftest.exp
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/selftest.exp,v
> > retrieving revision 1.4
> > diff -u -p -r1.4 selftest.exp
> > --- testsuite/gdb.base/selftest.exp	22 Jun 2002 22:19:37 -0000	1.4
> > +++ testsuite/gdb.base/selftest.exp	13 Oct 2002 22:55:02 -0000
> > @@ -392,7 +392,7 @@ GDB.*Copyright \[0-9\]+ Free Software Fo
> >      set description "backtrace through signal handler"
> >      send_gdb "backtrace\n"
> >      gdb_expect {
> > -	-re "#0.*read.*in main \\(.*\\) at .*main\\.c.*$gdb_prompt $" {
> > +	-re "#0.*(read|poll).*in main \\(.*\\) at .*gdb\\.c.*$gdb_prompt $" {
> >  	    pass "$description"
> >  	}
> >  	-re ".*$gdb_prompt $" {
> >