Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Print vector registers in natural format, not hex
Date: Fri, 04 Oct 2002 13:52:00 -0000	[thread overview]
Message-ID: <20021004205309.GA17616@nevyn.them.org> (raw)
In-Reply-To: <B4580F12-D7D9-11D6-866A-00039396EEB8@mit.edu>

Just got one nit.

On Fri, Oct 04, 2002 at 04:41:48PM -0400, Klee Dienes wrote:
> Before: 
> 
> (gdb) show architecture 
> The target architecture is set automatically (currently powerpc:common) 

>   v16_int8 = {0x60, 0x61, 0x62, 0x63, 0x64, 0x65, 0x66, 0x67, 0x40, 
> 0x49, 0xf, 0xdb, 0x40, 0x2d, 0xf8, 0x54} 

> After: 

>   v16_int8 = "`abcdefg@I\017°Z@-°ZT" 

First of all, in characters
  v16_int8 = {'`', 'a', 'b', 'c', 'd', 'e', 'f', 'g', '@', 'I', '\017', '°', 'Z', '@', '-', '°', 'Z', 'T'}

is more natural to me.  It's a vector of chars, not a string.

Secondly, this is an 'int8' type.  Are characters really the way to go?


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2002-10-04 20:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-04 13:41 Klee Dienes
2002-10-04 13:52 ` Daniel Jacobowitz [this message]
2002-10-04 14:11   ` Klee Dienes
2002-10-04 14:36     ` Daniel Jacobowitz
2002-10-18 16:23       ` Elena Zannoni
2002-11-04 20:02         ` Klee Dienes
2002-11-04 20:34           ` Daniel Jacobowitz
2002-10-05 10:29 ` Eli Zaretskii
2002-10-05 13:03   ` Klee Dienes
2002-10-06 11:31     ` Eli Zaretskii
2002-10-11  9:26       ` Klee Dienes
2002-10-12  2:01         ` Eli Zaretskii
2002-10-21 17:23         ` Andrew Cagney
2002-10-18 16:37 ` Elena Zannoni
2002-11-05  0:48   ` Klee Dienes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021004205309.GA17616@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox