From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4512 invoked by alias); 4 Oct 2002 20:52:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4503 invoked from network); 4 Oct 2002 20:52:36 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 4 Oct 2002 20:52:36 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17xaMy-0000T2-00 for ; Fri, 04 Oct 2002 16:52:24 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17xZRd-0004cb-00 for ; Fri, 04 Oct 2002 16:53:09 -0400 Date: Fri, 04 Oct 2002 13:52:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Print vector registers in natural format, not hex Message-ID: <20021004205309.GA17616@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2002-10/txt/msg00139.txt.bz2 Just got one nit. On Fri, Oct 04, 2002 at 04:41:48PM -0400, Klee Dienes wrote: > Before: > > (gdb) show architecture > The target architecture is set automatically (currently powerpc:common) > v16_int8 = {0x60, 0x61, 0x62, 0x63, 0x64, 0x65, 0x66, 0x67, 0x40, > 0x49, 0xf, 0xdb, 0x40, 0x2d, 0xf8, 0x54} > After: > v16_int8 = "`abcdefg@I\017°Z@-°ZT" First of all, in characters v16_int8 = {'`', 'a', 'b', 'c', 'd', 'e', 'f', 'g', '@', 'I', '\017', '°', 'Z', '@', '-', '°', 'Z', 'T'} is more natural to me. It's a vector of chars, not a string. Secondly, this is an 'int8' type. Are characters really the way to go? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer