From: Daniel Jacobowitz <drow@mvista.com>
To: Michael Snyder <msnyder@redhat.com>
Cc: David Carlton <carlton@math.stanford.edu>,
gdb-patches@sources.redhat.com
Subject: Re: [rfa] more all-target -Werror patches
Date: Tue, 01 Oct 2002 12:37:00 -0000 [thread overview]
Message-ID: <20021001193711.GA28905@nevyn.them.org> (raw)
In-Reply-To: <3D99F827.B5579C75@redhat.com>
On Tue, Oct 01, 2002 at 12:31:51PM -0700, Michael Snyder wrote:
> David Carlton wrote:
> >
> > Here are the last patches for getting GDB to build on my machine on
> > all targets with -Werror if appropriate.
> >
> > OK to commit? The gdb_string ones are pretty obvious; I'm not sure
> > why GCC is issuing a warning on remote-sds.c that requires me to
> > insert a stray semicolon to quell it, but doing so shouldn't hurt
> > anything.
>
> I'm uneasy about inserting semi-random stuff just to quiet a compiler
> complaint that doesn't necessarily make sense (is the compiler wrong?)
> Certainly it should be documented if you do it, else someone later may
> take it out, not knowing what it's there for.
Well, it's right. Labels without any expression to label aren't legal
C.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2002-10-01 19:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-01 9:18 David Carlton
2002-10-01 9:30 ` Andrew Cagney
2002-10-01 12:29 ` David Carlton
2002-10-01 12:32 ` Michael Snyder
2002-10-01 12:37 ` Daniel Jacobowitz [this message]
2002-10-01 12:43 ` David Carlton
2002-10-01 13:15 ` David Carlton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021001193711.GA28905@nevyn.them.org \
--to=drow@mvista.com \
--cc=carlton@math.stanford.edu \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox