From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3905 invoked by alias); 1 Oct 2002 19:37:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3846 invoked from network); 1 Oct 2002 19:37:06 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 1 Oct 2002 19:37:06 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17wTky-0002pT-00; Tue, 01 Oct 2002 15:36:36 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17wSpU-0007YF-00; Tue, 01 Oct 2002 15:37:12 -0400 Date: Tue, 01 Oct 2002 12:37:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: David Carlton , gdb-patches@sources.redhat.com Subject: Re: [rfa] more all-target -Werror patches Message-ID: <20021001193711.GA28905@nevyn.them.org> Mail-Followup-To: Michael Snyder , David Carlton , gdb-patches@sources.redhat.com References: <3D99F827.B5579C75@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D99F827.B5579C75@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-10/txt/msg00013.txt.bz2 On Tue, Oct 01, 2002 at 12:31:51PM -0700, Michael Snyder wrote: > David Carlton wrote: > > > > Here are the last patches for getting GDB to build on my machine on > > all targets with -Werror if appropriate. > > > > OK to commit? The gdb_string ones are pretty obvious; I'm not sure > > why GCC is issuing a warning on remote-sds.c that requires me to > > insert a stray semicolon to quell it, but doing so shouldn't hurt > > anything. > > I'm uneasy about inserting semi-random stuff just to quiet a compiler > complaint that doesn't necessarily make sense (is the compiler wrong?) > Certainly it should be documented if you do it, else someone later may > take it out, not knowing what it's there for. Well, it's right. Labels without any expression to label aren't legal C. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer