Re: [RFA/controversial] move bp by line number past the prologue

[Joel Brobecker <brobecker@gnat.com>]

On Thu, Aug 29, 2002 at 01:16:35PM -0700, Kevin Buettner wrote:
> My opinion is that this is a reasonable change providing that we
> still have a mechanism for setting a breakpoint on the prologue.
> When I want to do this I usually do ``b *foo'' instead of relying
> on line numbers.  (Usually I don't know the line number anyway.)

I completely agree.

> I've reread the thread in which this matter was discussed earlier
> (i.e, the "[RFC] breakpoints and function prologues" messages).  Given
> that there was such disagreement before, I doubt that everyone will
> agree with my point of view.  If this turns out to be the case, might
> I suggest a user settable option for controlling whether setting a
> breakpoint by line number will always cause the prologue to be
> skipped?  That way both sides get the behavior they want.  (GUIs can
> set the desired behavior at initialization time.)

How about this change? Any advice on the option name and description
would be appreciated. With this patch, the 5 regressions I was
mentioning in my previous e-mail can be cleared by turning this new
behavior off (there is also one other expected regression in help.exp,
since the output of "help breakpoint" is modified by this patch). Before
sending a patch for these regressions, I prefer to wait for comments
regarding this patch.

2002-08-30  Jim Ingham <jingham@apple.com>

        * linespec.c (decode_line_1): Skip the function prologue if
        funfirstline is set, unless adjust_break_after_prologue is
        unset by the user. Changes the behavior of the break command
        to skip the function prologue when breaking by line number.

2002-08-30  Joel Brobecker  <brobecker@gnat.com>

        * linespec.c (adjust_break_after_prologue): New static variable.
        (_initialize_linespec): New function.

        * Makefile.in: Update the dependencies for linespec.c

-- 
Joel