Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA/controversial] move bp by line number past the prologue
Date: Thu, 29 Aug 2002 13:20:00 -0000	[thread overview]
Message-ID: <1020829201635.ZM24274@localhost.localdomain> (raw)
In-Reply-To: Joel Brobecker <brobecker@gnat.com> "[RFA/controversial] move bp by line number past the prologue" (Aug 29, 11:15am)

On Aug 29, 11:15am, Joel Brobecker wrote:

> 2002-08-29  Jim Ingham <jingham@apple.com>
> 
>         * linespec.c (decode_line_1): Skip the function prologue if
>         funfirstline is set. Changes the behavior of the break command
>         to skip the function prologue when breaking by line number.

Joel,

My opinion is that this is a reasonable change providing that we
still have a mechanism for setting a breakpoint on the prologue.
When I want to do this I usually do ``b *foo'' instead of relying
on line numbers.  (Usually I don't know the line number anyway.)
So, I have no objection to this patch so long as it doesn't change
the present behavior of ``b *foo''.

I've reread the thread in which this matter was discussed earlier
(i.e, the "[RFC] breakpoints and function prologues" messages).  Given
that there was such disagreement before, I doubt that everyone will
agree with my point of view.  If this turns out to be the case, might
I suggest a user settable option for controlling whether setting a
breakpoint by line number will always cause the prologue to be
skipped?  That way both sides get the behavior they want.  (GUIs can
set the desired behavior at initialization time.)

Kevin


  reply	other threads:[~2002-08-29 20:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-29 11:37 Joel Brobecker
2002-08-29 13:20 ` Kevin Buettner [this message]
2002-08-29 13:37   ` Andrew Cagney
2002-08-29 14:50     ` Kevin Buettner
2002-08-29 15:30       ` Michael Snyder
2002-08-30 12:06   ` Joel Brobecker
2002-08-30 17:55     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1020829201635.ZM24274@localhost.localdomain \
    --to=kevinb@redhat.com \
    --cc=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox