* [RFA] Minor changes to proc-api.c for Interix
@ 2002-07-24 2:07 Joel Brobecker
2002-08-15 12:48 ` Joel Brobecker
2002-08-29 8:16 ` Joel Brobecker
0 siblings, 2 replies; 5+ messages in thread
From: Joel Brobecker @ 2002-07-24 2:07 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
Hello,
I would like to commit the following change. This change has been made
for Interix, but should not affect any other platform. Tested on
Solaris by recompiling GDB.
OK to commit?
2002-07-24 Donn Terry <dterry@microsoft.com>
* proc-api.c (rw_table): Do not include a row for PCDSTOP if the
corresponding macro is not defined. Likewise for PCNICE, PCSHOLD
and PCUNKILL.
(write_with_trace): Conditionalize out the switch branch handling
PCSHOLD if the corresponding macro is not defined. Likewise for
PRSABORT and PRSTOP.
This change will be needed by the Interix port.
Thanks,
--
Joel
[-- Attachment #2: proc-api.c.diff --]
[-- Type: text/plain, Size: 2817 bytes --]
Index: proc-api.c
===================================================================
RCS file: /cvs/src/src/gdb/proc-api.c,v
retrieving revision 1.13
diff -c -3 -p -r1.13 proc-api.c
*** proc-api.c 16 Jul 2002 17:14:13 -0000 1.13
--- proc-api.c 24 Jul 2002 07:06:28 -0000
*************** static struct trans rw_table[] = {
*** 397,405 ****
--- 397,409 ----
#ifdef PCCSIG /* solaris */
{ PCCSIG, "PCCSIG", "clear current signal" },
#endif
+ #ifdef PCDSTOP /* solaris */
{ PCDSTOP, "PCDSTOP", "post stop request" },
+ #endif
{ PCKILL, "PCKILL", "post a signal" },
+ #ifdef PCNICE /* solaris */
{ PCNICE, "PCNICE", "set nice priority" },
+ #endif
#ifdef PCREAD /* solaris */
{ PCREAD, "PCREAD", "read from the address space" },
{ PCWRITE, "PCWRITE", "write to the address space" },
*************** static struct trans rw_table[] = {
*** 419,425 ****
--- 423,431 ----
{ PCSEXIT, "PCSEXIT", "set traced syscall exit set" },
{ PCSFAULT, "PCSFAULT", "set traced fault set" },
{ PCSFPREG, "PCSFPREG", "set floating point registers" },
+ #ifdef PCHOLD /* solaris */
{ PCSHOLD, "PCSHOLD", "set signal mask" },
+ #endif
{ PCSREG, "PCSREG", "set general registers" },
{ PCSSIG, "PCSSIG", "set current signal" },
{ PCSTOP, "PCSTOP", "post stop request and wait" },
*************** static struct trans rw_table[] = {
*** 433,439 ****
--- 439,447 ----
#ifdef PCTWSTOP /* solaris */
{ PCTWSTOP, "PCTWSTOP", "wait for stop, with timeout arg" },
#endif
+ #ifdef PCUNKILL /* solaris */
{ PCUNKILL, "PCUNKILL", "delete a pending signal" },
+ #endif
#ifdef PCUNSET /* solaris */
{ PCUNSET, "PCUNSET", "unset modes" },
#endif
*************** write_with_trace (int fd, void *varg, si
*** 518,529 ****
--- 526,539 ----
proc_prettyfprint_syscalls (procfs_file ? procfs_file : stdout,
(sysset_t *) &arg[1], 0);
break;
+ #ifdef PCSHOLD
case PCSHOLD:
fprintf (procfs_file ? procfs_file : stdout,
"write (PCSHOLD) ");
proc_prettyfprint_signalset (procfs_file ? procfs_file : stdout,
(sigset_t *) &arg[1], 0);
break;
+ #endif
case PCSSIG:
fprintf (procfs_file ? procfs_file : stdout,
"write (PCSSIG) ");
*************** write_with_trace (int fd, void *varg, si
*** 542,551 ****
--- 552,565 ----
fprintf (procfs_file ? procfs_file : stdout, "clearFlt ");
if (arg[1] & PRSTEP)
fprintf (procfs_file ? procfs_file : stdout, "step ");
+ #ifdef PRSABORT
if (arg[1] & PRSABORT)
fprintf (procfs_file ? procfs_file : stdout, "syscallAbort ");
+ #endif
+ #ifdef PRSTOP
if (arg[1] & PRSTOP)
fprintf (procfs_file ? procfs_file : stdout, "stopReq ");
+ #endif
fprintf (procfs_file ? procfs_file : stdout, "\n");
break;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [RFA] Minor changes to proc-api.c for Interix
2002-07-24 2:07 [RFA] Minor changes to proc-api.c for Interix Joel Brobecker
@ 2002-08-15 12:48 ` Joel Brobecker
2002-08-22 15:54 ` Michael Snyder
2002-08-29 8:16 ` Joel Brobecker
1 sibling, 1 reply; 5+ messages in thread
From: Joel Brobecker @ 2002-08-15 12:48 UTC (permalink / raw)
To: gdb-patches
ping?
> I would like to commit the following change. This change has been made
> for Interix, but should not affect any other platform. Tested on
> Solaris by recompiling GDB.
>
> OK to commit?
>
> 2002-07-24 Donn Terry <dterry@microsoft.com>
>
> * proc-api.c (rw_table): Do not include a row for PCDSTOP if the
> corresponding macro is not defined. Likewise for PCNICE, PCSHOLD
> and PCUNKILL.
> (write_with_trace): Conditionalize out the switch branch handling
> PCSHOLD if the corresponding macro is not defined. Likewise for
> PRSABORT and PRSTOP.
> This change will be needed by the Interix port.
--
Joel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] Minor changes to proc-api.c for Interix
2002-08-15 12:48 ` Joel Brobecker
@ 2002-08-22 15:54 ` Michael Snyder
2002-08-23 8:30 ` Joel Brobecker
0 siblings, 1 reply; 5+ messages in thread
From: Michael Snyder @ 2002-08-22 15:54 UTC (permalink / raw)
To: Joel Brobecker; +Cc: gdb-patches
Joel Brobecker wrote:
>
> ping?
Yes, this is good, please check it in.
>
> > I would like to commit the following change. This change has been made
> > for Interix, but should not affect any other platform. Tested on
> > Solaris by recompiling GDB.
> >
> > OK to commit?
> >
> > 2002-07-24 Donn Terry <dterry@microsoft.com>
> >
> > * proc-api.c (rw_table): Do not include a row for PCDSTOP if the
> > corresponding macro is not defined. Likewise for PCNICE, PCSHOLD
> > and PCUNKILL.
> > (write_with_trace): Conditionalize out the switch branch handling
> > PCSHOLD if the corresponding macro is not defined. Likewise for
> > PRSABORT and PRSTOP.
> > This change will be needed by the Interix port.
>
> --
> Joel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] Minor changes to proc-api.c for Interix
2002-08-22 15:54 ` Michael Snyder
@ 2002-08-23 8:30 ` Joel Brobecker
0 siblings, 0 replies; 5+ messages in thread
From: Joel Brobecker @ 2002-08-23 8:30 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches
> Yes, this is good, please check it in.
Thank you. Committed.
> 2002-07-24 Donn Terry <dterry@microsoft.com>
>
> * proc-api.c (rw_table): Do not include a row for PCDSTOP if the
> corresponding macro is not defined. Likewise for PCNICE, PCSHOLD
> and PCUNKILL.
> (write_with_trace): Conditionalize out the switch branch handling
> PCSHOLD if the corresponding macro is not defined. Likewise for
> PRSABORT and PRSTOP.
> This change will be needed by the Interix port.
--
Joel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] Minor changes to proc-api.c for Interix
2002-07-24 2:07 [RFA] Minor changes to proc-api.c for Interix Joel Brobecker
2002-08-15 12:48 ` Joel Brobecker
@ 2002-08-29 8:16 ` Joel Brobecker
1 sibling, 0 replies; 5+ messages in thread
From: Joel Brobecker @ 2002-08-29 8:16 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]
> 2002-07-24 Donn Terry <dterry@microsoft.com>
>
> * proc-api.c (rw_table): Do not include a row for PCDSTOP if the
> corresponding macro is not defined. Likewise for PCNICE, PCSHOLD
> and PCUNKILL.
> (write_with_trace): Conditionalize out the switch branch handling
> PCSHOLD if the corresponding macro is not defined. Likewise for
> PRSABORT and PRSTOP.
> This change will be needed by the Interix port.
Donn pointed out to me that there is a typo in the following hunk
(missing 'S' in PCHOLD).
> *************** static struct trans rw_table[] = {
> *** 419,425 ****
> --- 423,431 ----
> { PCSEXIT, "PCSEXIT", "set traced syscall exit set" },
> { PCSFAULT, "PCSFAULT", "set traced fault set" },
> { PCSFPREG, "PCSFPREG", "set floating point registers" },
> + #ifdef PCHOLD /* solaris */
> { PCSHOLD, "PCSHOLD", "set signal mask" },
> + #endif
> { PCSREG, "PCSREG", "set general registers" },
> { PCSSIG, "PCSSIG", "set current signal" },
> { PCSTOP, "PCSTOP", "post stop request and wait" },
I fixed this obvious typo with the following change:
2002-08-29 Donn Terry <donnte@microsoft.com>
* proc-api.c (rw_table): Fix typo in #ifdef PCSHOLD (missing S).
--
Joel
[-- Attachment #2: proc-api.c.diff --]
[-- Type: text/plain, Size: 1004 bytes --]
Index: proc-api.c
===================================================================
RCS file: /cvs/src/src/gdb/proc-api.c,v
retrieving revision 1.14
diff -c -3 -p -r1.14 proc-api.c
*** proc-api.c 23 Aug 2002 15:06:53 -0000 1.14
--- proc-api.c 29 Aug 2002 13:17:31 -0000
*************** static struct trans rw_table[] = {
*** 423,429 ****
{ PCSEXIT, "PCSEXIT", "set traced syscall exit set" },
{ PCSFAULT, "PCSFAULT", "set traced fault set" },
{ PCSFPREG, "PCSFPREG", "set floating point registers" },
! #ifdef PCHOLD /* solaris */
{ PCSHOLD, "PCSHOLD", "set signal mask" },
#endif
{ PCSREG, "PCSREG", "set general registers" },
--- 423,429 ----
{ PCSEXIT, "PCSEXIT", "set traced syscall exit set" },
{ PCSFAULT, "PCSFAULT", "set traced fault set" },
{ PCSFPREG, "PCSFPREG", "set floating point registers" },
! #ifdef PCSHOLD /* solaris */
{ PCSHOLD, "PCSHOLD", "set signal mask" },
#endif
{ PCSREG, "PCSREG", "set general registers" },
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2002-08-29 15:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-07-24 2:07 [RFA] Minor changes to proc-api.c for Interix Joel Brobecker
2002-08-15 12:48 ` Joel Brobecker
2002-08-22 15:54 ` Michael Snyder
2002-08-23 8:30 ` Joel Brobecker
2002-08-29 8:16 ` Joel Brobecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox