[patch/in] Delete MIPS_DEFAULT_ABI

[patch/in] Delete MIPS_DEFAULT_ABI

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

FYI,

For Linux and NetBSD, defining this has no effect.  For IRIX it stops 
GDB defaulting to o32.

I'll commit, assuming testing goes ok ...
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 3343 bytes --]

2002-08-19  Andrew Cagney  <cagney@redhat.com>

	* config/mips/tm-nbsd.h (MIPS_DEFAULT_ABI): Delete.
	* config/mips/tm-linux.h (MIPS_DEFAULT_ABI): Delete.
	* config/mips/tm-irix5.h (MIPS_DEFAULT_ABI): Delete.
	* config/mips/tm-irix6.h (MIPS_DEFAULT_ABI): Delete.
	* mips-tdep.c (mips_gdbarch_init) [MIPS_DEFAULT_ABI]: Delete code.

Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.108
diff -u -r1.108 mips-tdep.c
--- mips-tdep.c	19 Aug 2002 23:22:17 -0000	1.108
+++ mips-tdep.c	20 Aug 2002 00:42:38 -0000
@@ -5509,11 +5509,6 @@
 	}
     }
 
-#ifdef MIPS_DEFAULT_ABI
-  if (mips_abi == MIPS_ABI_UNKNOWN)
-    mips_abi = MIPS_DEFAULT_ABI;
-#endif
-
   if (mips_abi == MIPS_ABI_UNKNOWN)
     mips_abi = MIPS_ABI_O32;
 
Index: config/mips/tm-irix5.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-irix5.h,v
retrieving revision 1.7
diff -u -r1.7 tm-irix5.h
--- config/mips/tm-irix5.h	11 Jun 2002 17:51:56 -0000	1.7
+++ config/mips/tm-irix5.h	20 Aug 2002 00:42:39 -0000
@@ -48,9 +48,6 @@
 	 : ((N) >= 70 && (N) <= 89) ? builtin_type_uint32 \
 	 : builtin_type_int)
 
-/* Force N32 ABI as the default. */
-#define MIPS_DEFAULT_ABI MIPS_ABI_N32
-
 #endif /* N32 */
 
 
Index: config/mips/tm-irix6.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-irix6.h,v
retrieving revision 1.4
diff -u -r1.4 tm-irix6.h
--- config/mips/tm-irix6.h	1 Aug 2002 19:57:41 -0000	1.4
+++ config/mips/tm-irix6.h	20 Aug 2002 00:42:39 -0000
@@ -88,10 +88,6 @@
       ((N) - FP0_REGNUM) * sizeof(double) : \
       32 * sizeof(double) + ((N) - 32) * MIPS_REGSIZE)
 
-/* Force N32 ABI as the default. */
-#define MIPS_DEFAULT_ABI MIPS_ABI_N32
-
-
 /* The signal handler trampoline is called _sigtramp.  */
 #undef IN_SIGTRAMP
 #define IN_SIGTRAMP(pc, name) ((name) && STREQ ("_sigtramp", name))
Index: config/mips/tm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-linux.h,v
retrieving revision 1.5
diff -u -r1.5 tm-linux.h
--- config/mips/tm-linux.h	19 Aug 2002 14:24:56 -0000	1.5
+++ config/mips/tm-linux.h	20 Aug 2002 00:42:39 -0000
@@ -40,11 +40,6 @@
 
 #include "config/tm-linux.h"
 
-/* There's an E_MIPS_ABI_O32 flag in e_flags, but we don't use it - in
-   fact, using it may violate the o32 ABI.  */
-
-#define MIPS_DEFAULT_ABI MIPS_ABI_O32
-
 /* Use target_specific function to define link map offsets.  */
 
 extern struct link_map_offsets *mips_linux_svr4_fetch_link_map_offsets (void);
Index: config/mips/tm-nbsd.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-nbsd.h,v
retrieving revision 1.1
diff -u -r1.1 tm-nbsd.h
--- config/mips/tm-nbsd.h	21 May 2002 15:58:41 -0000	1.1
+++ config/mips/tm-nbsd.h	20 Aug 2002 00:42:39 -0000
@@ -28,11 +28,6 @@
 #include "mips/tm-mips.h"
 #include "solib.h"
 
-/* There's an E_MIPS_ABI_O32 flag in e_flags, but we don't use it - in
-   fact, using it may violate the o32 ABI.  */
-
-#define MIPS_DEFAULT_ABI MIPS_ABI_O32
-
 /* We don't want to inherit tm-mips.h's shared library trampoline code.  */
 #undef IN_SOLIB_CALL_TRAMPOLINE
 #undef IN_SOLIB_RETURN_TRAMPOLINE

Re: [patch/in] Delete MIPS_DEFAULT_ABI

[Daniel Jacobowitz]

On Mon, Aug 19, 2002 at 08:45:14PM -0400, Andrew Cagney wrote:
> FYI,
> 
> For Linux and NetBSD, defining this has no effect.  For IRIX it stops 
> GDB defaulting to o32.
> 
> I'll commit, assuming testing goes ok ...
> Andrew

Stops IRIX defaulting to O32?  No, it _causes_ IRIX to default to O32. 
The only case in which this change has effect would have defaulted to
N32 before and now defaults to O32.

Not that I'm really complaining about your deleting the macro.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [patch/in] Delete MIPS_DEFAULT_ABI

[Andrew Cagney]

> On Mon, Aug 19, 2002 at 08:45:14PM -0400, Andrew Cagney wrote:
> 
>> FYI,
>> 
>> For Linux and NetBSD, defining this has no effect.  For IRIX it stops 
>> GDB defaulting to o32.
>> 
>> I'll commit, assuming testing goes ok ...
>> Andrew

For IRIX it [the presence of the macro MIPS_DEFAULT_ABI] stops GDB 
defaulting to o32.

> Stops IRIX defaulting to O32?  No, it _causes_ IRIX to default to O32. 
> The only case in which this change has effect would have defaulted to
> N32 before and now defaults to O32.

Yes.  It also gets rid of ~300 failures :-)

> Not that I'm really complaining about your deleting the macro.

commited,
Andrew