Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: RFA/remote: Clean up remote_open_1 and friend
Date: Sun, 18 Aug 2002 16:18:00 -0000	[thread overview]
Message-ID: <20020818231850.GA8176@nevyn.them.org> (raw)
In-Reply-To: <3D56820F.3060702@ges.redhat.com>

On Sun, Aug 11, 2002 at 11:26:07AM -0400, Andrew Cagney wrote:
> >I was looking at some future changes to remote_open_1, and didn't want to
> >duplicate them in remote_async_open_1, so I folded the two functions
> >together.  The changes were pretty small, and I think reasonable.  Andrew,
> >any thoughts?  This will let me kill the wrapper functions in a later 
> >patch,
> >I think.  I'm considering adding local state to the target stack right
> >now... which will make autodetecting which remote protocol to use even
> >simpler and cleaner.
> 
> Yes!
> 
> >+  remote_open_1 (name, from_tty, &extended_remote_ops, 1 /*extended_p */, 
> >0);
> 
> Can you just add a parameter name comment so it reads ``0 /* async_p */''.

Committed with that tweak.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


      reply	other threads:[~2002-08-18 23:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-10 20:42 Daniel Jacobowitz
2002-08-11  8:26 ` Andrew Cagney
2002-08-18 16:18   ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020818231850.GA8176@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox