From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30466 invoked by alias); 18 Aug 2002 23:18:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30459 invoked from network); 18 Aug 2002 23:18:14 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 18 Aug 2002 23:18:14 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17gZJK-0002vI-00 for ; Sun, 18 Aug 2002 18:18:18 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17gZJq-00028q-00 for ; Sun, 18 Aug 2002 19:18:50 -0400 Date: Sun, 18 Aug 2002 16:18:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: RFA/remote: Clean up remote_open_1 and friend Message-ID: <20020818231850.GA8176@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20020811034227.GA11733@nevyn.them.org> <3D56820F.3060702@ges.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D56820F.3060702@ges.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-08/txt/msg00531.txt.bz2 On Sun, Aug 11, 2002 at 11:26:07AM -0400, Andrew Cagney wrote: > >I was looking at some future changes to remote_open_1, and didn't want to > >duplicate them in remote_async_open_1, so I folded the two functions > >together. The changes were pretty small, and I think reasonable. Andrew, > >any thoughts? This will let me kill the wrapper functions in a later > >patch, > >I think. I'm considering adding local state to the target stack right > >now... which will make autodetecting which remote protocol to use even > >simpler and cleaner. > > Yes! > > >+ remote_open_1 (name, from_tty, &extended_remote_ops, 1 /*extended_p */, > >0); > > Can you just add a parameter name comment so it reads ``0 /* async_p */''. Committed with that tweak. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer