From: Daniel Jacobowitz <drow@mvista.com>
To: Andrew Cagney <ac131313@ges.redhat.com>
Cc: gdb-patches@sources.redhat.com, Mark Kettenis <kettenis@science.uva.nl>
Subject: Re: [patch/rfc] regcache_raw_read_as_address() -> regcache_cooked_read_as_ulongest()
Date: Mon, 12 Aug 2002 13:12:00 -0000 [thread overview]
Message-ID: <20020812201218.GA17509@nevyn.them.org> (raw)
In-Reply-To: <3D5811CA.2070205@ges.redhat.com>
On Mon, Aug 12, 2002 at 03:51:38PM -0400, Andrew Cagney wrote:
> Hello,
>
> This patch replaces the function regcache_raw_read_as_address() with the
> pair:
> regcache_cooked_read_as_longest()
> regcache_cooked_read_as_ulongest()
> The two calls to the old ..as_address() being replaced with the ulongest
> version.
>
> I think the change is ok (i386 shows no regressions, the mips doesn't
> use this code :-). I'm just wondering about the names. Perhaps:
> regcache_cooked_read_signed() & regcache_cooked_read_unsigned()?
>
> thoughts?
Hmm, I like _read_signed and _read_unsigned... the _as_longest bit is
implicit.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2002-08-12 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-12 12:51 Andrew Cagney
2002-08-12 12:57 ` Andrew Cagney
2002-08-12 13:12 ` Daniel Jacobowitz [this message]
[not found] ` <1020812202845.ZM934@localhost.localdomain>
2002-08-13 6:46 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020812201218.GA17509@nevyn.them.org \
--to=drow@mvista.com \
--cc=ac131313@ges.redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@science.uva.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox