From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8798 invoked by alias); 12 Aug 2002 20:12:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8791 invoked from network); 12 Aug 2002 20:11:59 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 12 Aug 2002 20:11:59 -0000 Received: from dsl093-061-169.pit1.dsl.speakeasy.net ([66.93.61.169] helo=nevyn.them.org ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17eLXk-0007by-00; Mon, 12 Aug 2002 15:12:00 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17eLY2-000510-00; Mon, 12 Aug 2002 16:12:18 -0400 Date: Mon, 12 Aug 2002 13:12:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: gdb-patches@sources.redhat.com, Mark Kettenis Subject: Re: [patch/rfc] regcache_raw_read_as_address() -> regcache_cooked_read_as_ulongest() Message-ID: <20020812201218.GA17509@nevyn.them.org> Mail-Followup-To: Andrew Cagney , gdb-patches@sources.redhat.com, Mark Kettenis References: <3D5811CA.2070205@ges.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D5811CA.2070205@ges.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-08/txt/msg00277.txt.bz2 On Mon, Aug 12, 2002 at 03:51:38PM -0400, Andrew Cagney wrote: > Hello, > > This patch replaces the function regcache_raw_read_as_address() with the > pair: > regcache_cooked_read_as_longest() > regcache_cooked_read_as_ulongest() > The two calls to the old ..as_address() being replaced with the ulongest > version. > > I think the change is ok (i386 shows no regressions, the mips doesn't > use this code :-). I'm just wondering about the names. Perhaps: > regcache_cooked_read_signed() & regcache_cooked_read_unsigned()? > > thoughts? Hmm, I like _read_signed and _read_unsigned... the _as_longest bit is implicit. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer