Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA] gdb/configure: Add check for sys/proc.h
@ 2002-07-07  8:46 Joel Brobecker
  2002-07-08 21:24 ` Andrew Cagney
  0 siblings, 1 reply; 3+ messages in thread
From: Joel Brobecker @ 2002-07-07  8:46 UTC (permalink / raw)
  To: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

This is in preparation for some later patches porting GDB to
i386-interix: when compiling proc-api.c, we try to include <sys/proc.h>
but this header file does not exist. I haven't checked this myself,
but I trust that the definitions that proc-api was needing from this
file will be found elsewhere. So I would like to conditionalize the
inclusion of this file using the HAVE_SYS_PROC_H macro. The following
patch introduces this macro.

2002-07-05  Joel Brobecker  <brobecker@gnat.com>

        Define HAVE_SYS_PROC_H if sys/proc.h exists
        * configure.in: Add check for sys/proc.h
        * config.in: Regenerate.
        * configure: Regenerate.

This patch has been tested on x86-linux (no sys/proc.h), and on
sparc-solaris (have sys/proc.h).

Ok to commit?

Thanks,
-- 
Joel

[-- Attachment #2: HAVE_SYS_PROC_H.diff --]
[-- Type: text/plain, Size: 3304 bytes --]

Index: configure.in
===================================================================
RCS file: /cvs/src/src/gdb/configure.in,v
retrieving revision 1.88
diff -c -3 -p -r1.88 configure.in
*** configure.in	21 Jun 2002 23:48:39 -0000	1.88
--- configure.in	6 Jul 2002 01:52:41 -0000
*************** esac; esac
*** 121,127 ****
  
  AC_CHECK_HEADERS(ctype.h nlist.h link.h thread_db.h proc_service.h \
  	memory.h objlist.h ptrace.h sgtty.h stddef.h stdlib.h \
! 	string.h sys/procfs.h sys/ptrace.h sys/reg.h stdint.h \
  	term.h termio.h termios.h unistd.h wait.h sys/wait.h \
  	wchar.h wctype.h asm/debugreg.h sys/debugreg.h sys/select.h \
  	time.h sys/file.h sys/ioctl.h sys/user.h sys/fault.h sys/syscall.h \
--- 121,127 ----
  
  AC_CHECK_HEADERS(ctype.h nlist.h link.h thread_db.h proc_service.h \
  	memory.h objlist.h ptrace.h sgtty.h stddef.h stdlib.h \
! 	string.h sys/procfs.h sys/proc.h sys/ptrace.h sys/reg.h stdint.h \
  	term.h termio.h termios.h unistd.h wait.h sys/wait.h \
  	wchar.h wctype.h asm/debugreg.h sys/debugreg.h sys/select.h \
  	time.h sys/file.h sys/ioctl.h sys/user.h sys/fault.h sys/syscall.h \
Index: config.in
===================================================================
RCS file: /cvs/src/src/gdb/config.in,v
retrieving revision 1.38
diff -c -3 -p -r1.38 config.in
*** config.in	21 Jun 2002 23:48:32 -0000	1.38
--- config.in	6 Jul 2002 01:52:36 -0000
***************
*** 367,372 ****
--- 367,375 ----
  /* Define if you have the <sys/poll.h> header file.  */
  #undef HAVE_SYS_POLL_H
  
+ /* Define if you have the <sys/proc.h> header file.  */
+ #undef HAVE_SYS_PROC_H
+ 
  /* Define if you have the <sys/procfs.h> header file.  */
  #undef HAVE_SYS_PROCFS_H
  
***************
*** 379,392 ****
  /* Define if you have the <sys/select.h> header file.  */
  #undef HAVE_SYS_SELECT_H
  
- /* Define if you have the <sys/stat.h> header file.  */
- #undef HAVE_SYS_STAT_H
- 
  /* Define if you have the <sys/syscall.h> header file.  */
  #undef HAVE_SYS_SYSCALL_H
- 
- /* Define if you have the <sys/types.h> header file.  */
- #undef HAVE_SYS_TYPES_H
  
  /* Define if you have the <sys/user.h> header file.  */
  #undef HAVE_SYS_USER_H
--- 382,389 ----
Index: configure
===================================================================
RCS file: /cvs/src/src/gdb/configure,v
retrieving revision 1.86
diff -c -3 -p -r1.86 configure
*** configure	21 Jun 2002 23:48:32 -0000	1.86
--- configure	6 Jul 2002 01:52:40 -0000
*************** esac; esac
*** 3389,3395 ****
  
  for ac_hdr in ctype.h nlist.h link.h thread_db.h proc_service.h \
  	memory.h objlist.h ptrace.h sgtty.h stddef.h stdlib.h \
! 	string.h sys/procfs.h sys/ptrace.h sys/reg.h stdint.h \
  	term.h termio.h termios.h unistd.h wait.h sys/wait.h \
  	wchar.h wctype.h asm/debugreg.h sys/debugreg.h sys/select.h \
  	time.h sys/file.h sys/ioctl.h sys/user.h sys/fault.h sys/syscall.h \
--- 3389,3395 ----
  
  for ac_hdr in ctype.h nlist.h link.h thread_db.h proc_service.h \
  	memory.h objlist.h ptrace.h sgtty.h stddef.h stdlib.h \
! 	string.h sys/procfs.h sys/proc.h sys/ptrace.h sys/reg.h stdint.h \
  	term.h termio.h termios.h unistd.h wait.h sys/wait.h \
  	wchar.h wctype.h asm/debugreg.h sys/debugreg.h sys/select.h \
  	time.h sys/file.h sys/ioctl.h sys/user.h sys/fault.h sys/syscall.h \

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA] gdb/configure: Add check for sys/proc.h
  2002-07-07  8:46 [RFA] gdb/configure: Add check for sys/proc.h Joel Brobecker
@ 2002-07-08 21:24 ` Andrew Cagney
  2002-07-09 16:16   ` Joel Brobecker
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2002-07-08 21:24 UTC (permalink / raw)
  To: Joel Brobecker; +Cc: gdb-patches

> This is in preparation for some later patches porting GDB to
> i386-interix: when compiling proc-api.c, we try to include <sys/proc.h>
> but this header file does not exist. I haven't checked this myself,
> but I trust that the definitions that proc-api was needing from this
> file will be found elsewhere. So I would like to conditionalize the
> inclusion of this file using the HAVE_SYS_PROC_H macro. The following
> patch introduces this macro.
> 
> 2002-07-05  Joel Brobecker  <brobecker@gnat.com>
> 
>         Define HAVE_SYS_PROC_H if sys/proc.h exists
>         * configure.in: Add check for sys/proc.h
>         * config.in: Regenerate.
>         * configure: Regenerate.
> 
> This patch has been tested on x86-linux (no sys/proc.h), and on
> sparc-solaris (have sys/proc.h).
> 
> Ok to commit?

Yes.  In general, any developer ``brave enough'' can commit changes to 
configure.in.  Just post them first for comment.

Can you just check that you're using the BINUTILS 000227 autoconf.  I'm 
asking as I noticed:

> ***************
> *** 379,392 ****
>   /* Define if you have the <sys/select.h> header file.  */
>   #undef HAVE_SYS_SELECT_H
>   
> - /* Define if you have the <sys/stat.h> header file.  */
> - #undef HAVE_SYS_STAT_H
> - 
>   /* Define if you have the <sys/syscall.h> header file.  */
>   #undef HAVE_SYS_SYSCALL_H
> - 
> - /* Define if you have the <sys/types.h> header file.  */
> - #undef HAVE_SYS_TYPES_H
>   
>   /* Define if you have the <sys/user.h> header file.  */
>   #undef HAVE_SYS_USER_H

which has me puzzled.  I suspect it might just be that config.in is 
out-of-datem dig dig.  Yep :-/

Andrew



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA] gdb/configure: Add check for sys/proc.h
  2002-07-08 21:24 ` Andrew Cagney
@ 2002-07-09 16:16   ` Joel Brobecker
  0 siblings, 0 replies; 3+ messages in thread
From: Joel Brobecker @ 2002-07-09 16:16 UTC (permalink / raw)
  To: Andrew Cagney; +Cc: gdb-patches

Thank you, the change has been committed to the trunk.

> Can you just check that you're using the BINUTILS 000227 autoconf.  I'm 
> asking as I noticed:

I wasn't, but I am now :-).

-- 
Joel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2002-07-09 23:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-07-07  8:46 [RFA] gdb/configure: Add check for sys/proc.h Joel Brobecker
2002-07-08 21:24 ` Andrew Cagney
2002-07-09 16:16   ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox