From: Daniel Jacobowitz <drow@mvista.com>
To: Michal Ludvig <mludvig@suse.cz>
Cc: GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [patch] gdbserver for x86-64
Date: Thu, 04 Jul 2002 07:48:00 -0000 [thread overview]
Message-ID: <20020704134526.GA12086@nevyn.them.org> (raw)
In-Reply-To: <3D23E57E.8030007@suse.cz>
On Thu, Jul 04, 2002 at 08:04:46AM +0200, Michal Ludvig wrote:
> Daniel Jacobowitz wrote:
> >On Wed, Jul 03, 2002 at 04:40:58PM +0200, Michal Ludvig wrote:
> >>2002-07-03 Michal Ludvig <mludvig@suse.cz>
> >>
> >> * gdbserver/linux-x86-64-low.c (x86_64_fill_gregset): Change type in
> >> explicit cast to CORE_ADDR so that pointer arithmetic works.
> >> (x86_64_store_gregset): Ditto + parameter made const.
> >> (x86_64_store_fpregset): Parameter made const.
> >
> >
> >Could you change the reg_map instead, please? It's used outside of
> >this file and expected to be in byte offsets.
>
> Where is it used? It seems to be a static array without any reference
> from outside.
Oh, you're right. Because x86-64 only uses GETREGS, it doesn't expose
the regmap.
> >Just add *4 or *8 where appropriate as I did in the i386 file.
>
> OK, changed and committed as in the attached file.
Thanks!
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
prev parent reply other threads:[~2002-07-04 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-03 8:02 Michal Ludvig
2002-07-03 8:05 ` Daniel Jacobowitz
2002-07-04 0:22 ` Michal Ludvig
2002-07-04 7:48 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020704134526.GA12086@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=mludvig@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox