From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24093 invoked by alias); 4 Jul 2002 13:45:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24011 invoked from network); 4 Jul 2002 13:45:25 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 4 Jul 2002 13:45:25 -0000 Received: from dsl254-114-096.nyc1.dsl.speakeasy.net ([216.254.114.96] helo=nevyn.them.org) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17Q6vC-0000Fi-00; Thu, 04 Jul 2002 08:45:22 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17Q6vH-0003Ao-00; Thu, 04 Jul 2002 09:45:27 -0400 Date: Thu, 04 Jul 2002 07:48:00 -0000 From: Daniel Jacobowitz To: Michal Ludvig Cc: GDB Patches Subject: Re: [patch] gdbserver for x86-64 Message-ID: <20020704134526.GA12086@nevyn.them.org> Mail-Followup-To: Michal Ludvig , GDB Patches References: <3D230CFA.5060602@suse.cz> <20020703150155.GA9114@nevyn.them.org> <3D23E57E.8030007@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D23E57E.8030007@suse.cz> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-07/txt/msg00079.txt.bz2 On Thu, Jul 04, 2002 at 08:04:46AM +0200, Michal Ludvig wrote: > Daniel Jacobowitz wrote: > >On Wed, Jul 03, 2002 at 04:40:58PM +0200, Michal Ludvig wrote: > >>2002-07-03 Michal Ludvig > >> > >> * gdbserver/linux-x86-64-low.c (x86_64_fill_gregset): Change type in > >> explicit cast to CORE_ADDR so that pointer arithmetic works. > >> (x86_64_store_gregset): Ditto + parameter made const. > >> (x86_64_store_fpregset): Parameter made const. > > > > > >Could you change the reg_map instead, please? It's used outside of > >this file and expected to be in byte offsets. > > Where is it used? It seems to be a static array without any reference > from outside. Oh, you're right. Because x86-64 only uses GETREGS, it doesn't expose the regmap. > >Just add *4 or *8 where appropriate as I did in the i386 file. > > OK, changed and committed as in the attached file. Thanks! -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer