Re: [patch/rfc] dummy frames using regcache

[Daniel Jacobowitz <drow@mvista.com>]

On Fri, Jun 28, 2002 at 06:38:59PM -0400, Andrew Cagney wrote:
> >Hello,
> >
> >Attached is the next in the regcache series.  This converts dummy frames 
> >to the regcache.  Tested on the i386.
> >
> >Note the fixme though:
> >
> >+      /* FIXME: cagney/2002-06-26: This should be via the
> >+         gdbarch_register_read() method so that it, on the fly,
> >+         constructs either a raw or pseudo register from the raw
> >+         register cache.  */
> >+      regcache_read (registers, regnum, bufferp);
> 
> FYI,
> 
> >2002-06-26  Andrew Cagney  <ac131313@redhat.com>
> >
> >	* blockframe.c (generic_find_dummy_frame): Change return type to
> >	``struct regcache''.
> >	(struct dummy_frame): Replace field ``registers'' with regcache, a
> >	struct regcache object.
> >	(generic_find_dummy_frame): Update.
> >	(generic_push_dummy_frame): Update.  Use regcache_xfree,
> >	regcache_xmalloc and regcache_cpy.
> >	(generic_pop_dummy_frame): Update.  Use regcache_cpy and
> >	regcache_xfree.
> >	(deprecated_generic_find_dummy_frame): Update.
> >	(generic_read_register_dummy): Update.  Use
> >	regcache_read_as_address.
> >	(generic_call_dummy_register_unwind): Update.  Use regcache_read.
> >
> 
> I've now checked this in (.....holds breath ...).

Great!  I'm working on a port where this'll be very helpful.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer