From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26043 invoked by alias); 28 Jun 2002 22:40:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26036 invoked from network); 28 Jun 2002 22:40:58 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 28 Jun 2002 22:40:58 -0000 Received: from 02-099.118.popsite.net ([66.19.120.99] helo=nevyn.them.org) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17O4QB-0005qO-00; Fri, 28 Jun 2002 17:40:55 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17O4QE-0004Vr-00; Fri, 28 Jun 2002 18:40:58 -0400 Date: Fri, 28 Jun 2002 15:40:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] dummy frames using regcache Message-ID: <20020628224058.GA17332@nevyn.them.org> Mail-Followup-To: Andrew Cagney , gdb-patches@sources.redhat.com References: <3D1A1F43.6090405@ges.redhat.com> <3D1CE583.4090801@ges.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D1CE583.4090801@ges.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-06/txt/msg00579.txt.bz2 On Fri, Jun 28, 2002 at 06:38:59PM -0400, Andrew Cagney wrote: > >Hello, > > > >Attached is the next in the regcache series. This converts dummy frames > >to the regcache. Tested on the i386. > > > >Note the fixme though: > > > >+ /* FIXME: cagney/2002-06-26: This should be via the > >+ gdbarch_register_read() method so that it, on the fly, > >+ constructs either a raw or pseudo register from the raw > >+ register cache. */ > >+ regcache_read (registers, regnum, bufferp); > > FYI, > > >2002-06-26 Andrew Cagney > > > > * blockframe.c (generic_find_dummy_frame): Change return type to > > ``struct regcache''. > > (struct dummy_frame): Replace field ``registers'' with regcache, a > > struct regcache object. > > (generic_find_dummy_frame): Update. > > (generic_push_dummy_frame): Update. Use regcache_xfree, > > regcache_xmalloc and regcache_cpy. > > (generic_pop_dummy_frame): Update. Use regcache_cpy and > > regcache_xfree. > > (deprecated_generic_find_dummy_frame): Update. > > (generic_read_register_dummy): Update. Use > > regcache_read_as_address. > > (generic_call_dummy_register_unwind): Update. Use regcache_read. > > > > I've now checked this in (.....holds breath ...). Great! I'm working on a port where this'll be very helpful. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer