Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jason R Thorpe <thorpej@wasabisystems.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: Michael Elizabeth Chastain <mec@shout.net>,
	gdb-patches@sources.redhat.com
Subject: Re: [rfa:ppc] Fix PPC/NBSD struct return; Was: userdef.exp regression for ppc?
Date: Sun, 02 Jun 2002 13:29:00 -0000	[thread overview]
Message-ID: <20020602132916.G27682@dr-evil.shagadelic.org> (raw)
In-Reply-To: <3CF902B0.50405@cygnus.com>; from ac131313@cygnus.com on Sat, Jun 01, 2002 at 01:21:52PM -0400

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

On Sat, Jun 01, 2002 at 01:21:52PM -0400, Andrew Cagney wrote:

 > The old code, for reasons I'm not sure, was failing to detect NetBSD and 
 > hence was failing ot set it.

Here is the patch I checked in.

        * ppcnbsd-tdep.c (ppcnbsd_init_abi): Don't set
        use_struct_convention to ppc_sysv_abi_broken_use_struct_convention.

-- 
        -- Jason R. Thorpe <thorpej@wasabisystems.com>

[-- Attachment #2: ppc-patch --]
[-- Type: text/plain, Size: 908 bytes --]

Index: ppcnbsd-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ppcnbsd-tdep.c,v
retrieving revision 1.1
diff -u -r1.1 ppcnbsd-tdep.c
--- ppcnbsd-tdep.c	28 May 2002 18:43:07 -0000	1.1
+++ ppcnbsd-tdep.c	2 Jun 2002 20:26:01 -0000
@@ -200,12 +200,6 @@
 ppcnbsd_init_abi (struct gdbarch_info info,
                   struct gdbarch *gdbarch)
 {
-  /* Until November 2001, gcc was not complying to the SYSV ABI for
-     returning structures less than or equal to 8 bytes in size. It was
-     returning everything in memory. When this was corrected, it wasn't
-     fixed for native platforms.  */
-  set_gdbarch_use_struct_convention (gdbarch,
-                                   ppc_sysv_abi_broken_use_struct_convention);
 
   set_solib_svr4_fetch_link_map_offsets (gdbarch,
                                 nbsd_ilp32_solib_svr4_fetch_link_map_offsets);

  parent reply	other threads:[~2002-06-02 20:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-01  8:46 Michael Elizabeth Chastain
2002-06-01 10:21 ` [rfa:ppc] Fix PPC/NBSD struct return; Was: " Andrew Cagney
2002-06-01 15:03   ` Jason R Thorpe
2002-06-02 11:15   ` Jason R Thorpe
2002-06-02 11:51   ` Jason R Thorpe
2002-06-02 12:24     ` Zack Weinberg
2002-06-02 13:29   ` Jason R Thorpe [this message]
2002-06-03  6:13     ` Andrew Cagney
2002-06-03 11:30 ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020602132916.G27682@dr-evil.shagadelic.org \
    --to=thorpej@wasabisystems.com \
    --cc=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mec@shout.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox