From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16798 invoked by alias); 2 Jun 2002 20:29:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16791 invoked from network); 2 Jun 2002 20:29:17 -0000 Received: from unknown (HELO dr-evil.shagadelic.org) (208.176.2.162) by sources.redhat.com with SMTP; 2 Jun 2002 20:29:17 -0000 Received: by dr-evil.shagadelic.org (Postfix, from userid 7518) id B9D7E9869; Sun, 2 Jun 2002 13:29:16 -0700 (PDT) Date: Sun, 02 Jun 2002 13:29:00 -0000 From: Jason R Thorpe To: Andrew Cagney Cc: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com Subject: Re: [rfa:ppc] Fix PPC/NBSD struct return; Was: userdef.exp regression for ppc? Message-ID: <20020602132916.G27682@dr-evil.shagadelic.org> Mail-Followup-To: Jason R Thorpe , Andrew Cagney , Michael Elizabeth Chastain , gdb-patches@sources.redhat.com References: <200206011546.g51FkMj30586@duracef.shout.net> <3CF902B0.50405@cygnus.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="1UWUbFP1cBYEclgG" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <3CF902B0.50405@cygnus.com>; from ac131313@cygnus.com on Sat, Jun 01, 2002 at 01:21:52PM -0400 Organization: Wasabi Systems, Inc. X-SW-Source: 2002-06/txt/msg00032.txt.bz2 --1UWUbFP1cBYEclgG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 398 On Sat, Jun 01, 2002 at 01:21:52PM -0400, Andrew Cagney wrote: > The old code, for reasons I'm not sure, was failing to detect NetBSD and > hence was failing ot set it. Here is the patch I checked in. * ppcnbsd-tdep.c (ppcnbsd_init_abi): Don't set use_struct_convention to ppc_sysv_abi_broken_use_struct_convention. -- -- Jason R. Thorpe --1UWUbFP1cBYEclgG Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=ppc-patch Content-length: 908 Index: ppcnbsd-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/ppcnbsd-tdep.c,v retrieving revision 1.1 diff -u -r1.1 ppcnbsd-tdep.c --- ppcnbsd-tdep.c 28 May 2002 18:43:07 -0000 1.1 +++ ppcnbsd-tdep.c 2 Jun 2002 20:26:01 -0000 @@ -200,12 +200,6 @@ ppcnbsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) { - /* Until November 2001, gcc was not complying to the SYSV ABI for - returning structures less than or equal to 8 bytes in size. It was - returning everything in memory. When this was corrected, it wasn't - fixed for native platforms. */ - set_gdbarch_use_struct_convention (gdbarch, - ppc_sysv_abi_broken_use_struct_convention); set_solib_svr4_fetch_link_map_offsets (gdbarch, nbsd_ilp32_solib_svr4_fetch_link_map_offsets); --1UWUbFP1cBYEclgG--