From: Richard Earnshaw <rearnsha@arm.com>
To: gdb-patches@sources.redhat.com
Cc: Richard.Earnshaw@arm.com
Subject: [PATCH/RFA] builtin-regs buglet
Date: Mon, 13 May 2002 09:04:00 -0000 [thread overview]
Message-ID: <200205131603.RAA22964@cam-mail2.cambridge.arm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 304 bytes --]
I think this probably come under obvious, but lets see what others think.
With my new ARM pseudo-registers code, I'm getting an internal error if I
type
(gdb) p $fp
Why? Well there's some missing brackets...
* builtin-regs.c (value_of_builtin_reg): Correctly calculate the
builtin reg number.
[-- Attachment #2: gdb-builtin.patch --]
[-- Type: text/x-patch , Size: 839 bytes --]
Index: builtin-regs.c
===================================================================
RCS file: /cvs/src/src/gdb/builtin-regs.c,v
retrieving revision 1.1
diff -p -r1.1 builtin-regs.c
*** builtin-regs.c 9 Apr 2002 03:06:13 -0000 1.1
--- builtin-regs.c 13 May 2002 15:59:50 -0000
*************** builtin_reg_map_name_to_regnum (const ch
*** 71,77 ****
struct value *
value_of_builtin_reg (int regnum, struct frame_info *frame)
{
! int reg = regnum - NUM_REGS + NUM_PSEUDO_REGS;
gdb_assert (reg >= 0 && reg < nr_builtin_regs);
return builtin_regs[reg].value (frame);
}
--- 71,77 ----
struct value *
value_of_builtin_reg (int regnum, struct frame_info *frame)
{
! int reg = regnum - (NUM_REGS + NUM_PSEUDO_REGS);
gdb_assert (reg >= 0 && reg < nr_builtin_regs);
return builtin_regs[reg].value (frame);
}
next reply other threads:[~2002-05-13 16:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-13 9:04 Richard Earnshaw [this message]
2002-05-13 9:22 ` Andrew Cagney
2002-05-13 9:27 ` Richard Earnshaw
2002-05-14 17:34 ` Andrew Cagney
2002-05-15 1:52 ` Richard Earnshaw
2002-05-18 14:24 ` Andrew Cagney
2002-05-19 7:50 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200205131603.RAA22964@cam-mail2.cambridge.arm.com \
--to=rearnsha@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox