From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28947 invoked by alias); 13 May 2002 16:04:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28927 invoked from network); 13 May 2002 16:04:05 -0000 Received: from unknown (HELO fw-cam.cambridge.arm.com) (193.131.176.3) by sources.redhat.com with SMTP; 13 May 2002 16:04:05 -0000 Received: by fw-cam.cambridge.arm.com; id RAA18247; Mon, 13 May 2002 17:04:04 +0100 (BST) Received: from unknown(172.16.1.2) by fw-cam.cambridge.arm.com via smap (V5.5) id xma017551; Mon, 13 May 02 17:03:05 +0100 Received: from cam-mail2.cambridge.arm.com (cam-mail2.cambridge.arm.com [172.16.1.91]) by cam-admin0.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id RAA22214 for ; Mon, 13 May 2002 17:03:05 +0100 (BST) Received: from sun18.cambridge.arm.com (sun18.cambridge.arm.com [172.16.2.18]) by cam-mail2.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id RAA22964; Mon, 13 May 2002 17:03:04 +0100 (BST) Message-Id: <200205131603.RAA22964@cam-mail2.cambridge.arm.com> To: gdb-patches@sources.redhat.com cc: Richard.Earnshaw@arm.com Reply-To: Richard.Earnshaw@arm.com Organization: ARM Ltd. X-Telephone: +44 1223 400569 (direct+voicemail), +44 1223 400400 (switchbd) X-Fax: +44 1223 400410 X-Address: ARM Ltd., 110 Fulbourn Road, Cherry Hinton, Cambridge CB1 9NJ. X-Url: http://www.arm.com/ Subject: [PATCH/RFA] builtin-regs buglet Mime-Version: 1.0 Content-Type: multipart/mixed ; boundary="==_Exmh_-17809174100" Date: Mon, 13 May 2002 09:04:00 -0000 From: Richard Earnshaw X-SW-Source: 2002-05/txt/msg00462.txt.bz2 This is a multipart MIME message. --==_Exmh_-17809174100 Content-Type: text/plain; charset=us-ascii Content-length: 304 I think this probably come under obvious, but lets see what others think. With my new ARM pseudo-registers code, I'm getting an internal error if I type (gdb) p $fp Why? Well there's some missing brackets... * builtin-regs.c (value_of_builtin_reg): Correctly calculate the builtin reg number. --==_Exmh_-17809174100 Content-Type: text/x-patch ; name="gdb-builtin.patch"; charset=us-ascii Content-Description: gdb-builtin.patch Content-Disposition: attachment; filename="gdb-builtin.patch" Content-length: 839 Index: builtin-regs.c =================================================================== RCS file: /cvs/src/src/gdb/builtin-regs.c,v retrieving revision 1.1 diff -p -r1.1 builtin-regs.c *** builtin-regs.c 9 Apr 2002 03:06:13 -0000 1.1 --- builtin-regs.c 13 May 2002 15:59:50 -0000 *************** builtin_reg_map_name_to_regnum (const ch *** 71,77 **** struct value * value_of_builtin_reg (int regnum, struct frame_info *frame) { ! int reg = regnum - NUM_REGS + NUM_PSEUDO_REGS; gdb_assert (reg >= 0 && reg < nr_builtin_regs); return builtin_regs[reg].value (frame); } --- 71,77 ---- struct value * value_of_builtin_reg (int regnum, struct frame_info *frame) { ! int reg = regnum - (NUM_REGS + NUM_PSEUDO_REGS); gdb_assert (reg >= 0 && reg < nr_builtin_regs); return builtin_regs[reg].value (frame); } --==_Exmh_-17809174100--