From: Jason R Thorpe <thorpej@wasabisystems.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH/RFC] Generic OS ABI handling for gdbarch
Date: Mon, 13 May 2002 08:49:00 -0000 [thread overview]
Message-ID: <20020513084908.T3435@dr-evil.shagadelic.org> (raw)
In-Reply-To: <3CDF4D07.2050805@cygnus.com>; from ac131313@cygnus.com on Mon, May 13, 2002 at 01:20:07AM -0400
On Mon, May 13, 2002 at 01:20:07AM -0400, Andrew Cagney wrote:
> > +/* List of known OS ABIs. If you change this, make sure to update the
> > + table in osabi.c. */
>
> Suggest checking this in _initialize_osabi().
Ok. Sufficient to check that the last one is NULL?
> What is the overhead of the ``sniff test''? Can I suggest checking all
> regardless and then internal_error()ing on a double hit.
>
> In the one hand, this means looking for trouble. On the other hand, it
> is the only way we'll flush out some bugs before the next release.
I don't think the overhead is that much. I mean, it only happens once
at the start of the debugging session, anyway, and I think sniffing the
BFD is going to be a lot faster than loading the symbol table of most
things, anyway :-)
So, I'll make this tweak, as well.
--
-- Jason R. Thorpe <thorpej@wasabisystems.com>
next prev parent reply other threads:[~2002-05-13 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-11 21:20 Jason R Thorpe
2002-05-12 10:06 ` Jason R Thorpe
2002-05-12 21:50 ` Eli Zaretskii
2002-05-12 22:00 ` Jason R Thorpe
2002-05-12 22:27 ` Eli Zaretskii
2002-05-12 22:20 ` Andrew Cagney
2002-05-13 8:49 ` Jason R Thorpe [this message]
2002-05-13 9:10 ` Andrew Cagney
2002-05-13 9:13 ` Jason R Thorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020513084908.T3435@dr-evil.shagadelic.org \
--to=thorpej@wasabisystems.com \
--cc=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox