From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17390 invoked by alias); 13 May 2002 15:49:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17383 invoked from network); 13 May 2002 15:49:09 -0000 Received: from unknown (HELO dr-evil.shagadelic.org) (208.176.2.162) by sources.redhat.com with SMTP; 13 May 2002 15:49:09 -0000 Received: by dr-evil.shagadelic.org (Postfix, from userid 7518) id 933069869; Mon, 13 May 2002 08:49:08 -0700 (PDT) Date: Mon, 13 May 2002 08:49:00 -0000 From: Jason R Thorpe To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFC] Generic OS ABI handling for gdbarch Message-ID: <20020513084908.T3435@dr-evil.shagadelic.org> Reply-To: thorpej@wasabisystems.com Mail-Followup-To: Jason R Thorpe , Andrew Cagney , gdb-patches@sources.redhat.com References: <20020511212045.I3435@dr-evil.shagadelic.org> <3CDF4D07.2050805@cygnus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <3CDF4D07.2050805@cygnus.com>; from ac131313@cygnus.com on Mon, May 13, 2002 at 01:20:07AM -0400 Organization: Wasabi Systems, Inc. X-SW-Source: 2002-05/txt/msg00459.txt.bz2 On Mon, May 13, 2002 at 01:20:07AM -0400, Andrew Cagney wrote: > > +/* List of known OS ABIs. If you change this, make sure to update the > > + table in osabi.c. */ > > Suggest checking this in _initialize_osabi(). Ok. Sufficient to check that the last one is NULL? > What is the overhead of the ``sniff test''? Can I suggest checking all > regardless and then internal_error()ing on a double hit. > > In the one hand, this means looking for trouble. On the other hand, it > is the only way we'll flush out some bugs before the next release. I don't think the overhead is that much. I mean, it only happens once at the start of the debugging session, anyway, and I think sniffing the BFD is going to be a lot faster than loading the symbol table of most things, anyway :-) So, I'll make this tweak, as well. -- -- Jason R. Thorpe