Re: [PATCH/RFA] Don't gdbarch_init for core files

[Jason R Thorpe <thorpej@wasabisystems.com>]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

On Thu, May 09, 2002 at 11:04:27PM -0400, Andrew Cagney wrote:

 > Instead of removing the call, is it possible to reasonably detect if the 
 > core file belongs to the current architecture (either in corefile.c) or 
 > in gdbarch_FOO_init().

How about this?

	* corelow.c (core_open): If the core's arch is known and
	different from the current, reinitialize gdbarch based on
	the core file.

-- 
        -- Jason R. Thorpe <thorpej@wasabisystems.com>

[-- Attachment #2: core-patch --]
[-- Type: text/plain, Size: 1021 bytes --]

Index: corelow.c
===================================================================
RCS file: /cvs/src/src/gdb/corelow.c,v
retrieving revision 1.21
diff -u -r1.21 corelow.c
--- corelow.c	5 May 2002 01:15:13 -0000	1.21
+++ corelow.c	10 May 2002 04:14:05 -0000
@@ -264,6 +264,7 @@
   bfd *temp_bfd;
   int ontop;
   int scratch_chan;
+  const struct bfd_arch_info *current_arch_info;
 
   target_preopen (from_tty);
   if (!filename)
@@ -321,7 +322,13 @@
     error ("\"%s\": Can't find sections: %s",
 	   bfd_get_filename (core_bfd), bfd_errmsg (bfd_get_error ()));
 
-  set_gdbarch_from_file (core_bfd);
+  /* If the core's arch is known and different from the current,
+     reinitialize gdbarch based on the core file.  */
+
+  current_arch_info = gdbarch_bfd_arch_info (current_gdbarch);
+  if (core_bfd->arch_info->arch != bfd_arch_unknown
+      && core_bfd->arch_info->arch != current_arch_info->arch)
+    set_gdbarch_from_file (core_bfd);
 
   ontop = !push_target (&core_ops);
   discard_cleanups (old_chain);