From: Michael Snyder <msnyder@cygnus.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA/RFC] Tweak for a gdb.mi test.
Date: Tue, 07 May 2002 18:22:00 -0000 [thread overview]
Message-ID: <200205080109.g4819B821604@reddwarf.sfbay.redhat.com> (raw)
I'm gonna ask for a second pair of eyes, since I don't know MI
very well.
What this is -- the test is examining the stack, but it is
assuming that main is the last frame. My change allows for
one extra frame below main (eg. for '_start').
OK to check in?
Michael
2002-05-07 Michael Snyder <msnyder@redhat.com>
* gdb.mi/mi-stack.exp (test_stack_args_listing): Allow for
an optional frame for the caller of main (eg. '_start').
(test_stack_info_depth): Ditto.
* gdb.mi/mi0-stack.exp (test_stack_args_listing): Allow for
an optional frame for the caller of main (eg. '_start').
(test_stack_info_depth): Ditto.
Index: mi-stack.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-stack.exp,v
retrieving revision 1.8
diff -p -r1.8 mi-stack.exp
*** mi-stack.exp 19 Aug 2001 01:23:43 -0000 1.8
--- mi-stack.exp 8 May 2002 01:13:42 -0000
*************** proc test_stack_args_listing {} {
*** 101,108 ****
# -stack-list-arguments 1 1 3
# -stack-list-arguments
mi_gdb_test "231-stack-list-arguments 0" \
! "231\\^done,stack-args=\\\[frame=\{level=\"0\",args=\\\[\\\]\},frame=\{level=\"1\",args=\\\[name=\"strarg\"\\\]\},frame=\{level=\"2\",args=\\\[name=\"intarg\",name=\"strarg\"\\\]\},frame=\{level=\"3\",args=\\\[name=\"intarg\",name=\"strarg\",name=\"fltarg\"\\\]\},frame=\{level=\"4\",args=\\\[\\\]\}\\\]" \
"stack args listing 0"
mi_gdb_test "232-stack-list-arguments 0 1 1" \
--- 101,109 ----
# -stack-list-arguments 1 1 3
# -stack-list-arguments
+ # Allow for an optional fifth frame ("_start" or whatever...)
mi_gdb_test "231-stack-list-arguments 0" \
! "231\\^done,stack-args=\\\[frame=\{level=\"0\",args=\\\[\\\]\},frame=\{level=\"1\",args=\\\[name=\"strarg\"\\\]\},frame=\{level=\"2\",args=\\\[name=\"intarg\",name=\"strarg\"\\\]\},frame=\{level=\"3\",args=\\\[name=\"intarg\",name=\"strarg\",name=\"fltarg\"\\\]\},frame=\{level=\"4\",args=\\\[\\\]\}(,frame=\{level=\"5\",args=\\\[\\\]\}|)\\\]" \
"stack args listing 0"
mi_gdb_test "232-stack-list-arguments 0 1 1" \
*************** proc test_stack_args_listing {} {
*** 113,120 ****
"233\\^done,stack-args=\\\[frame=\{level=\"1\",args=\\\[name=\"strarg\"\\\]\},frame=\{level=\"2\",args=\\\[name=\"intarg\",name=\"strarg\"\\\]\},frame=\{level=\"3\",args=\\\[name=\"intarg\",name=\"strarg\",name=\"fltarg\"\\\]\}\\\]" \
"stack args listing 0 1 3"
mi_gdb_test "231-stack-list-arguments 1" \
! "231\\^done,stack-args=\\\[frame=\{level=\"0\",args=\\\[\\\]\},frame=\{level=\"1\",args=\\\[\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\\\]\},frame=\{level=\"2\",args=\\\[\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\\\]\},frame=\{level=\"3\",args=\\\[\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\},\{name=\"fltarg\",value=\"3.5\"\}\\\]\},frame=\{level=\"4\",args=\\\[\\\]\}\\\]" \
"stack args listing 1"
mi_gdb_test "232-stack-list-arguments 1 1 1" \
--- 114,122 ----
"233\\^done,stack-args=\\\[frame=\{level=\"1\",args=\\\[name=\"strarg\"\\\]\},frame=\{level=\"2\",args=\\\[name=\"intarg\",name=\"strarg\"\\\]\},frame=\{level=\"3\",args=\\\[name=\"intarg\",name=\"strarg\",name=\"fltarg\"\\\]\}\\\]" \
"stack args listing 0 1 3"
+ # Allow for an optional fifth frame ("_start" or whatever...)
mi_gdb_test "231-stack-list-arguments 1" \
! "231\\^done,stack-args=\\\[frame=\{level=\"0\",args=\\\[\\\]\},frame=\{level=\"1\",args=\\\[\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\\\]\},frame=\{level=\"2\",args=\\\[\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\\\]\},frame=\{level=\"3\",args=\\\[\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\},\{name=\"fltarg\",value=\"3.5\"\}\\\]\},frame=\{level=\"4\",args=\\\[\\\]\}(,frame=\{level=\"5\",args=\\\[\\\]\}|)\\\]" \
"stack args listing 1"
mi_gdb_test "232-stack-list-arguments 1 1 1" \
*************** proc test_stack_info_depth {} {
*** 140,155 ****
# -stack-info-depth 3
# -stack-info-depth 99
mi_gdb_test "231-stack-info-depth" \
! "231\\^done,depth=\"5\"" \
"stack info-depth"
mi_gdb_test "231-stack-info-depth 3" \
"231\\^done,depth=\"3\"" \
"stack info-depth 3"
mi_gdb_test "231-stack-info-depth 99" \
! "231\\^done,depth=\"5\"" \
"stack info-depth 99"
mi_gdb_test "231-stack-info-depth 99 99" \
--- 142,159 ----
# -stack-info-depth 3
# -stack-info-depth 99
+ # Allow for an optional fifth frame ("_start" or whatever...)
mi_gdb_test "231-stack-info-depth" \
! "231\\^done,depth=\"(5|6)\"" \
"stack info-depth"
mi_gdb_test "231-stack-info-depth 3" \
"231\\^done,depth=\"3\"" \
"stack info-depth 3"
+ # Allow for an optional fifth frame ("_start" or whatever...)
mi_gdb_test "231-stack-info-depth 99" \
! "231\\^done,depth=\"(5|6)\"" \
"stack info-depth 99"
mi_gdb_test "231-stack-info-depth 99 99" \
Index: mi0-stack.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi0-stack.exp,v
retrieving revision 1.4
diff -p -r1.4 mi0-stack.exp
*** mi0-stack.exp 19 Aug 2001 01:23:43 -0000 1.4
--- mi0-stack.exp 8 May 2002 01:13:42 -0000
*************** proc test_stack_args_listing {} {
*** 101,108 ****
# -stack-list-arguments 1 1 3
# -stack-list-arguments
mi_gdb_test "231-stack-list-arguments 0" \
! "231\\^done,stack-args=\{frame=\{level=\"0\",args=\{\}\},frame=\{level=\"1\",args=\{name=\"strarg\"\}\},frame=\{level=\"2\",args=\{name=\"intarg\",name=\"strarg\"\}\},frame=\{level=\"3\",args=\{name=\"intarg\",name=\"strarg\",name=\"fltarg\"\}\},frame=\{level=\"4\",args=\{\}\}\}" \
"stack args listing 0"
mi_gdb_test "232-stack-list-arguments 0 1 1" \
--- 101,109 ----
# -stack-list-arguments 1 1 3
# -stack-list-arguments
+ # Allow for an optional fifth frame ("_start" or whatever...)
mi_gdb_test "231-stack-list-arguments 0" \
! "231\\^done,stack-args=\{frame=\{level=\"0\",args=\{\}\},frame=\{level=\"1\",args=\{name=\"strarg\"\}\},frame=\{level=\"2\",args=\{name=\"intarg\",name=\"strarg\"\}\},frame=\{level=\"3\",args=\{name=\"intarg\",name=\"strarg\",name=\"fltarg\"\}\},frame=\{level=\"4\",args=\{\}\}(,frame=\{level=\"5\",args=\{\}\}|)\}" \
"stack args listing 0"
mi_gdb_test "232-stack-list-arguments 0 1 1" \
*************** proc test_stack_args_listing {} {
*** 113,120 ****
"233\\^done,stack-args=\{frame=\{level=\"1\",args=\{name=\"strarg\"\}\},frame=\{level=\"2\",args=\{name=\"intarg\",name=\"strarg\"\}\},frame=\{level=\"3\",args=\{name=\"intarg\",name=\"strarg\",name=\"fltarg\"\}\}\}" \
"stack args listing 0 1 3"
mi_gdb_test "231-stack-list-arguments 1" \
! "231\\^done,stack-args=\{frame=\{level=\"0\",args=\{\}\},frame=\{level=\"1\",args=\{\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\}\},frame=\{level=\"2\",args=\{\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\}\},frame=\{level=\"3\",args=\{\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\},\{name=\"fltarg\",value=\"3.5\"\}\}\},frame=\{level=\"4\",args=\{\}\}\}" \
"stack args listing 1"
mi_gdb_test "232-stack-list-arguments 1 1 1" \
--- 114,122 ----
"233\\^done,stack-args=\{frame=\{level=\"1\",args=\{name=\"strarg\"\}\},frame=\{level=\"2\",args=\{name=\"intarg\",name=\"strarg\"\}\},frame=\{level=\"3\",args=\{name=\"intarg\",name=\"strarg\",name=\"fltarg\"\}\}\}" \
"stack args listing 0 1 3"
+ # Allow for an optional fifth frame ("_start" or whatever...)
mi_gdb_test "231-stack-list-arguments 1" \
! "231\\^done,stack-args=\{frame=\{level=\"0\",args=\{\}\},frame=\{level=\"1\",args=\{\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\}\},frame=\{level=\"2\",args=\{\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\}\},frame=\{level=\"3\",args=\{\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\},\{name=\"fltarg\",value=\"3.5\"\}\}\},frame=\{level=\"4\",args=\{\}\}(,frame=\{level=\"5\",args=\{\}\}|)\}" \
"stack args listing 1"
mi_gdb_test "232-stack-list-arguments 1 1 1" \
*************** proc test_stack_info_depth {} {
*** 141,147 ****
# -stack-info-depth 99
mi_gdb_test "231-stack-info-depth" \
! "231\\^done,depth=\"5\"" \
"stack info-depth"
mi_gdb_test "231-stack-info-depth 3" \
--- 143,149 ----
# -stack-info-depth 99
mi_gdb_test "231-stack-info-depth" \
! "231\\^done,depth=\"(5|6)\"" \
"stack info-depth"
mi_gdb_test "231-stack-info-depth 3" \
*************** proc test_stack_info_depth {} {
*** 149,155 ****
"stack info-depth 3"
mi_gdb_test "231-stack-info-depth 99" \
! "231\\^done,depth=\"5\"" \
"stack info-depth 99"
mi_gdb_test "231-stack-info-depth 99 99" \
--- 151,157 ----
"stack info-depth 3"
mi_gdb_test "231-stack-info-depth 99" \
! "231\\^done,depth=\"(5|6)\"" \
"stack info-depth 99"
mi_gdb_test "231-stack-info-depth 99 99" \
next reply other threads:[~2002-05-08 1:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-07 18:22 Michael Snyder [this message]
2002-05-07 18:30 ` Daniel Jacobowitz
2002-05-07 19:03 ` Michael Snyder
2002-05-07 19:42 ` Daniel Jacobowitz
2002-05-07 19:04 ` Andrew Cagney
2002-05-07 19:15 ` Michael Snyder
2002-05-07 20:06 ` Andrew Cagney
2002-05-08 13:50 ` Michael Snyder
2002-05-08 15:52 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200205080109.g4819B821604@reddwarf.sfbay.redhat.com \
--to=msnyder@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox