From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1900 invoked by alias); 8 May 2002 01:22:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1745 invoked from network); 8 May 2002 01:22:13 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 8 May 2002 01:22:13 -0000 Received: from reddwarf.sfbay.redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id SAA07680 for ; Tue, 7 May 2002 18:22:13 -0700 (PDT) Received: (from msnyder@localhost) by reddwarf.sfbay.redhat.com (8.11.2/8.11.2) id g4819B821604 for gdb-patches@sources.redhat.com; Tue, 7 May 2002 18:09:11 -0700 Date: Tue, 07 May 2002 18:22:00 -0000 From: Michael Snyder Message-Id: <200205080109.g4819B821604@reddwarf.sfbay.redhat.com> To: gdb-patches@sources.redhat.com Subject: [RFA/RFC] Tweak for a gdb.mi test. X-SW-Source: 2002-05/txt/msg00189.txt.bz2 I'm gonna ask for a second pair of eyes, since I don't know MI very well. What this is -- the test is examining the stack, but it is assuming that main is the last frame. My change allows for one extra frame below main (eg. for '_start'). OK to check in? Michael 2002-05-07 Michael Snyder * gdb.mi/mi-stack.exp (test_stack_args_listing): Allow for an optional frame for the caller of main (eg. '_start'). (test_stack_info_depth): Ditto. * gdb.mi/mi0-stack.exp (test_stack_args_listing): Allow for an optional frame for the caller of main (eg. '_start'). (test_stack_info_depth): Ditto. Index: mi-stack.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-stack.exp,v retrieving revision 1.8 diff -p -r1.8 mi-stack.exp *** mi-stack.exp 19 Aug 2001 01:23:43 -0000 1.8 --- mi-stack.exp 8 May 2002 01:13:42 -0000 *************** proc test_stack_args_listing {} { *** 101,108 **** # -stack-list-arguments 1 1 3 # -stack-list-arguments mi_gdb_test "231-stack-list-arguments 0" \ ! "231\\^done,stack-args=\\\[frame=\{level=\"0\",args=\\\[\\\]\},frame=\{level=\"1\",args=\\\[name=\"strarg\"\\\]\},frame=\{level=\"2\",args=\\\[name=\"intarg\",name=\"strarg\"\\\]\},frame=\{level=\"3\",args=\\\[name=\"intarg\",name=\"strarg\",name=\"fltarg\"\\\]\},frame=\{level=\"4\",args=\\\[\\\]\}\\\]" \ "stack args listing 0" mi_gdb_test "232-stack-list-arguments 0 1 1" \ --- 101,109 ---- # -stack-list-arguments 1 1 3 # -stack-list-arguments + # Allow for an optional fifth frame ("_start" or whatever...) mi_gdb_test "231-stack-list-arguments 0" \ ! "231\\^done,stack-args=\\\[frame=\{level=\"0\",args=\\\[\\\]\},frame=\{level=\"1\",args=\\\[name=\"strarg\"\\\]\},frame=\{level=\"2\",args=\\\[name=\"intarg\",name=\"strarg\"\\\]\},frame=\{level=\"3\",args=\\\[name=\"intarg\",name=\"strarg\",name=\"fltarg\"\\\]\},frame=\{level=\"4\",args=\\\[\\\]\}(,frame=\{level=\"5\",args=\\\[\\\]\}|)\\\]" \ "stack args listing 0" mi_gdb_test "232-stack-list-arguments 0 1 1" \ *************** proc test_stack_args_listing {} { *** 113,120 **** "233\\^done,stack-args=\\\[frame=\{level=\"1\",args=\\\[name=\"strarg\"\\\]\},frame=\{level=\"2\",args=\\\[name=\"intarg\",name=\"strarg\"\\\]\},frame=\{level=\"3\",args=\\\[name=\"intarg\",name=\"strarg\",name=\"fltarg\"\\\]\}\\\]" \ "stack args listing 0 1 3" mi_gdb_test "231-stack-list-arguments 1" \ ! "231\\^done,stack-args=\\\[frame=\{level=\"0\",args=\\\[\\\]\},frame=\{level=\"1\",args=\\\[\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\\\]\},frame=\{level=\"2\",args=\\\[\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\\\]\},frame=\{level=\"3\",args=\\\[\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\},\{name=\"fltarg\",value=\"3.5\"\}\\\]\},frame=\{level=\"4\",args=\\\[\\\]\}\\\]" \ "stack args listing 1" mi_gdb_test "232-stack-list-arguments 1 1 1" \ --- 114,122 ---- "233\\^done,stack-args=\\\[frame=\{level=\"1\",args=\\\[name=\"strarg\"\\\]\},frame=\{level=\"2\",args=\\\[name=\"intarg\",name=\"strarg\"\\\]\},frame=\{level=\"3\",args=\\\[name=\"intarg\",name=\"strarg\",name=\"fltarg\"\\\]\}\\\]" \ "stack args listing 0 1 3" + # Allow for an optional fifth frame ("_start" or whatever...) mi_gdb_test "231-stack-list-arguments 1" \ ! "231\\^done,stack-args=\\\[frame=\{level=\"0\",args=\\\[\\\]\},frame=\{level=\"1\",args=\\\[\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\\\]\},frame=\{level=\"2\",args=\\\[\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\\\]\},frame=\{level=\"3\",args=\\\[\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\},\{name=\"fltarg\",value=\"3.5\"\}\\\]\},frame=\{level=\"4\",args=\\\[\\\]\}(,frame=\{level=\"5\",args=\\\[\\\]\}|)\\\]" \ "stack args listing 1" mi_gdb_test "232-stack-list-arguments 1 1 1" \ *************** proc test_stack_info_depth {} { *** 140,155 **** # -stack-info-depth 3 # -stack-info-depth 99 mi_gdb_test "231-stack-info-depth" \ ! "231\\^done,depth=\"5\"" \ "stack info-depth" mi_gdb_test "231-stack-info-depth 3" \ "231\\^done,depth=\"3\"" \ "stack info-depth 3" mi_gdb_test "231-stack-info-depth 99" \ ! "231\\^done,depth=\"5\"" \ "stack info-depth 99" mi_gdb_test "231-stack-info-depth 99 99" \ --- 142,159 ---- # -stack-info-depth 3 # -stack-info-depth 99 + # Allow for an optional fifth frame ("_start" or whatever...) mi_gdb_test "231-stack-info-depth" \ ! "231\\^done,depth=\"(5|6)\"" \ "stack info-depth" mi_gdb_test "231-stack-info-depth 3" \ "231\\^done,depth=\"3\"" \ "stack info-depth 3" + # Allow for an optional fifth frame ("_start" or whatever...) mi_gdb_test "231-stack-info-depth 99" \ ! "231\\^done,depth=\"(5|6)\"" \ "stack info-depth 99" mi_gdb_test "231-stack-info-depth 99 99" \ Index: mi0-stack.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi0-stack.exp,v retrieving revision 1.4 diff -p -r1.4 mi0-stack.exp *** mi0-stack.exp 19 Aug 2001 01:23:43 -0000 1.4 --- mi0-stack.exp 8 May 2002 01:13:42 -0000 *************** proc test_stack_args_listing {} { *** 101,108 **** # -stack-list-arguments 1 1 3 # -stack-list-arguments mi_gdb_test "231-stack-list-arguments 0" \ ! "231\\^done,stack-args=\{frame=\{level=\"0\",args=\{\}\},frame=\{level=\"1\",args=\{name=\"strarg\"\}\},frame=\{level=\"2\",args=\{name=\"intarg\",name=\"strarg\"\}\},frame=\{level=\"3\",args=\{name=\"intarg\",name=\"strarg\",name=\"fltarg\"\}\},frame=\{level=\"4\",args=\{\}\}\}" \ "stack args listing 0" mi_gdb_test "232-stack-list-arguments 0 1 1" \ --- 101,109 ---- # -stack-list-arguments 1 1 3 # -stack-list-arguments + # Allow for an optional fifth frame ("_start" or whatever...) mi_gdb_test "231-stack-list-arguments 0" \ ! "231\\^done,stack-args=\{frame=\{level=\"0\",args=\{\}\},frame=\{level=\"1\",args=\{name=\"strarg\"\}\},frame=\{level=\"2\",args=\{name=\"intarg\",name=\"strarg\"\}\},frame=\{level=\"3\",args=\{name=\"intarg\",name=\"strarg\",name=\"fltarg\"\}\},frame=\{level=\"4\",args=\{\}\}(,frame=\{level=\"5\",args=\{\}\}|)\}" \ "stack args listing 0" mi_gdb_test "232-stack-list-arguments 0 1 1" \ *************** proc test_stack_args_listing {} { *** 113,120 **** "233\\^done,stack-args=\{frame=\{level=\"1\",args=\{name=\"strarg\"\}\},frame=\{level=\"2\",args=\{name=\"intarg\",name=\"strarg\"\}\},frame=\{level=\"3\",args=\{name=\"intarg\",name=\"strarg\",name=\"fltarg\"\}\}\}" \ "stack args listing 0 1 3" mi_gdb_test "231-stack-list-arguments 1" \ ! "231\\^done,stack-args=\{frame=\{level=\"0\",args=\{\}\},frame=\{level=\"1\",args=\{\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\}\},frame=\{level=\"2\",args=\{\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\}\},frame=\{level=\"3\",args=\{\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\},\{name=\"fltarg\",value=\"3.5\"\}\}\},frame=\{level=\"4\",args=\{\}\}\}" \ "stack args listing 1" mi_gdb_test "232-stack-list-arguments 1 1 1" \ --- 114,122 ---- "233\\^done,stack-args=\{frame=\{level=\"1\",args=\{name=\"strarg\"\}\},frame=\{level=\"2\",args=\{name=\"intarg\",name=\"strarg\"\}\},frame=\{level=\"3\",args=\{name=\"intarg\",name=\"strarg\",name=\"fltarg\"\}\}\}" \ "stack args listing 0 1 3" + # Allow for an optional fifth frame ("_start" or whatever...) mi_gdb_test "231-stack-list-arguments 1" \ ! "231\\^done,stack-args=\{frame=\{level=\"0\",args=\{\}\},frame=\{level=\"1\",args=\{\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\}\},frame=\{level=\"2\",args=\{\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\}\}\},frame=\{level=\"3\",args=\{\{name=\"intarg\",value=\"2\"\},\{name=\"strarg\",value=\"$hex \\\\\"A string argument.\\\\\"\"\},\{name=\"fltarg\",value=\"3.5\"\}\}\},frame=\{level=\"4\",args=\{\}\}(,frame=\{level=\"5\",args=\{\}\}|)\}" \ "stack args listing 1" mi_gdb_test "232-stack-list-arguments 1 1 1" \ *************** proc test_stack_info_depth {} { *** 141,147 **** # -stack-info-depth 99 mi_gdb_test "231-stack-info-depth" \ ! "231\\^done,depth=\"5\"" \ "stack info-depth" mi_gdb_test "231-stack-info-depth 3" \ --- 143,149 ---- # -stack-info-depth 99 mi_gdb_test "231-stack-info-depth" \ ! "231\\^done,depth=\"(5|6)\"" \ "stack info-depth" mi_gdb_test "231-stack-info-depth 3" \ *************** proc test_stack_info_depth {} { *** 149,155 **** "stack info-depth 3" mi_gdb_test "231-stack-info-depth 99" \ ! "231\\^done,depth=\"5\"" \ "stack info-depth 99" mi_gdb_test "231-stack-info-depth 99 99" \ --- 151,157 ---- "stack info-depth 3" mi_gdb_test "231-stack-info-depth 99" \ ! "231\\^done,depth=\"(5|6)\"" \ "stack info-depth 99" mi_gdb_test "231-stack-info-depth 99 99" \